rbd: default image format to v2 instead of deprecated v1 #51574
Conversation
Image format v1 has been deprecated since the Infernalis release of Ceph over two years ago.
k8s-ci-robot
added
size/XS
|
Hi @dillaman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Updated examples: kubernetes/examples#88 |
k8s-github-robot
added
the
release-note
|
I'm the upstream Ceph PTL for RBD -- we are trying to discourage the use of the old, deprecated RBD v1 image format. v2 has been supported in the Linux kernel since v3.8. |
| @@ -291,7 +291,7 @@ func (r *rbdVolumeProvisioner) Provision() (*v1.PersistentVolume, error) { | |||
| adminSecretNamespace := rbdDefaultAdminSecretNamespace | |||
| secretName := "" | |||
| secret := "" | |||
| imageFormat := rbdImageFormat1 | |||
| imageFormat := rbdImageFormat2 | |||
There was a problem hiding this comment.
Does this require any new packages or configuration to change? Could this break existing users on upgrade?
There was a problem hiding this comment.
Negative -- RBD v2 images have been supported for 5+ years and krbd/librbd can transparently open v1 and v2 images. The only thing changing here is that newly created images, by default, will use the v2 on-disk format.
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @rootfs |
|
/approve thank you! |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dillaman, msau42, rootfs Associated issue requirement bypassed by: rootfs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/retest Review the full test history for this PR. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@dillaman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 51574, 51534, 49257, 44680, 48836) |
What this PR does / why we need it:
Image format v1 has been deprecated since the Infernalis release of
Ceph over two years ago.
Release note:
StorageClass Ceph RBD now defaults to using the v2 image format