Re-add the defer statements around the monitor() calls in the apiserver. #5147
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, that's why it was like that. Sorry about that. What do you think about making the monitor function take pointers instead of requiring everything to be in closures? |
…pointers. This is needed for the changes to various labels from later in the function to be picked up.
|
Fine by me! Done. |
|
LGTM, will merge on green |
lavalamp
added a commit
that referenced
this pull request
Mar 6, 2015
Re-add the defer statements around the monitor() calls in the apiserver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are needed for the changes to various labels from later in the function are picked up. They were incorrectly removed in #4507, causing the fields to always be empty in all exported metrics.
If you would prefer a different way of enabling this behavior I'd be happy to change to it, but we can't remove the closures without inserting some other logic to replace them.