Describe how to use publicIPs to access guestbook externally when not us... #5144
Conversation
… using external load balancers
| @@ -368,6 +368,7 @@ The service is described in the file `examples/guestbook/frontend-service.json`: | |||
| "apiVersion": "v1beta1", | |||
| "port": 8000, | |||
| "containerPort": "http-server", | |||
| "publicIPs":["10.11.22.33"], | |||
There was a problem hiding this comment.
By changing the json here, it makes it so that this block no longer matches the file that the readme text claims it is pulled from.
There was a problem hiding this comment.
+1 I suggest explaining in the text how and why to add this field.
|
Thats true. but There isn't much need to add it to the raw jsons (because it by nature is specific to a system you're running on - so it will be very awkward). So i think in this corner-case, its good to deviate from the actual json files. Its easier to grok this by seeing it embedded in the json file for the example, rather than write a long sentence explaining how it can appended to the json file. |
|
I'd suggest showing it without and how to add it, or adding a line explaining why it differs from the source file. |
|
Fair enough :) modified @lavalamp @roberthbailey ... I added a line above, describing the modification. Also i squashed the commits. |
|
LGTM, thanks. |
Describe how to use publicIPs to access guestbook externally when not us...
...ing external load balancers