Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting old sample JSON; moving those in use; updating references #5124

Merged
merged 1 commit into from
Mar 9, 2015
Merged

Conversation

MikeJeffrey
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@bgrant0607
Copy link
Member

LGTM, but you need to run gofmt on examples/examples_test.go before we can merge this. Sorry.

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2015
@bgrant0607 bgrant0607 removed their assignment Mar 6, 2015
@brendandburns brendandburns self-assigned this Mar 6, 2015
@MikeJeffrey
Copy link
Contributor Author

Thanks! Ran gofmt -s -w. PTAL - many thanks for your help in getting this sorted :)

@bgrant0607
Copy link
Member

LGTM

@alex-mohr alex-mohr added cla: yes kind/documentation Categorizes issue or PR as related to documentation. and removed cla: no labels Mar 9, 2015
alex-mohr added a commit that referenced this pull request Mar 9, 2015
Deleting old sample JSON; moving those in use; updating references
@alex-mohr alex-mohr merged commit ee276b2 into kubernetes:master Mar 9, 2015
@satnam6502
Copy link
Contributor

Has this broken our build?

--- FAIL: TestExampleObjectSchemas (0.04s)
    examples_test.go:174: Expected no error, Got lstat ../docs/getting-started-guides: no such file or directory
    examples_test.go:177: Expected 1 examples, Got 0

@bgrant0607
Copy link
Member

Travis is green.

@satnam6502
Copy link
Contributor

OK, I am past this error and onto the next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants