-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run multiarch/qemu-user-static:register before building cross-arch images #51141
Conversation
/lgtm |
/lgtm |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, when/how did this get removed :(?
Anyway, thanks @ixdy for noticing and adding it back.
/lgtm
Feel free to add the approved label someone or do /approve
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: david-mcmahon, ixdy, luxas, mbohlool, mikedanese Associated issue: 48365 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 50489, 51070, 51011, 51022, 51141) |
What this PR does / why we need it: #48365 inadvertently broke building non-x86 hyperkube images for developers who'd not built non-x86 images before and thus hadn't yet run
multiarch/qemu-user-static:register
. This PR restores that step.Release note:
/assign @david-mcmahon @mbohlool @luxas