Fix StatefulSet update validation #51051
Merged
+55
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/apps
janetkuo
added
the
release-note-none
k8s-github-robot
added
the
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-kubernetes-e2e-gce-etcd3 |
kow3ns
approved these changes
Aug 22, 2017
|
/lgtm |
|
/approve |
|
/approve no-issue
…On Tue, Aug 22, 2017 at 6:34 PM, Kubernetes Submit Queue < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *crimsonfaith91
<#51051 (comment)>*,
*erictune
<#51051 (comment)>*,
*janetkuo <#51051#>*, *kow3ns
<#51051 (comment)>*
*No associated issue*. Update pull-request body to add a reference to an
issue, or get approval with /approve no-issue
The full list of commands accepted by this bot can be found here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
Needs approval from an approver in each of these OWNERS Files:
- pkg/apis/OWNERS
<https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS>
[erictune]
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51051 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p7kW8jtqYysiiWe72XBdoSjehyj4ks5sa1d8gaJpZM4O95ht>
.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crimsonfaith91, erictune, janetkuo, kow3ns, smarterclayton Associated issue requirement bypassed by: smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 50980, 46902, 51051, 51062, 51020) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatefulSet update validation did not allow change to number of containers in pod template. Fix this bug so that it's possible to make this kind of change.
Found it when suggesting test-cmd changes in #49674.
@kubernetes/sig-apps-pr-reviews @smarterclayton
/approve no-issue