Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node e2e tests for the CPU Manager. #51041

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Node e2e tests for the CPU Manager. #51041

merged 1 commit into from
Sep 12, 2017

Conversation

balajismaniam
Copy link
Contributor

@balajismaniam balajismaniam commented Aug 21, 2017 •
edited
Loading

What this PR does / why we need it:

Special notes for your reviewer:

To run this node e2e test, use the following command:

make test-e2e-node TEST_ARGS='--feature-gates=DynamicKubeletConfig=true' FOCUS="CPU Manager" SKIP="" PARALLELISM=1

CC @ConnorDoyle @sjenning

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2017
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Aug 21, 2017
@ConnorDoyle
Copy link
Contributor

/assign @sjenning @derekwaynecarr @ConnorDoyle

@derekwaynecarr
Copy link
Member

i will defer commenting on this too deeply until prereq pr merges (which i have reviewed)

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2017
@thockin thockin assigned vishh and unassigned thockin Aug 22, 2017
@ConnorDoyle ConnorDoyle mentioned this pull request Aug 23, 2017
Closed
6 tasks
@ConnorDoyle
Copy link
Contributor

Blocker for CPU manager #49186 (6 of 6)

@k8s-github-robot k8s-github-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Aug 29, 2017
@ConnorDoyle
Copy link
Contributor

@derekwaynecarr please add v1.8 milestone

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2017
@ConnorDoyle ConnorDoyle mentioned this pull request Aug 30, 2017
Merged
@k8s-github-robot k8s-github-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 30, 2017
@sjenning
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Aug 31, 2017
@k8s-github-robot k8s-github-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 31, 2017
@balajismaniam
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-gpu

@balajismaniam
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-bazel

@balajismaniam
Copy link
Contributor Author

@ConnorDoyle All tests are happy now.

@ConnorDoyle
Copy link
Contributor

Successful run on local 8 core machine.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2017
derekwaynecarr
derekwaynecarr reviewed Sep 11, 2017
View reviewed changes
test/e2e_node/cpu_manager_test.go Outdated

func waitForContainerRemoval(ctnPartName string) {
Eventually(func() bool {
err := exec.Command("/bin/sh", "-c", fmt.Sprintf("if [ -n \"$(docker ps -a | grep -i %s)\" ]; then exit 1; fi", ctnPartName)).Run()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if i am not running docker?

Copy link
Contributor Author

@balajismaniam balajismaniam Sep 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the TODO comment here as well.

derekwaynecarr
derekwaynecarr reviewed Sep 11, 2017
View reviewed changes
test/e2e_node/cpu_manager_test.go Outdated

func enableCPUManagerInKubelet(f *framework.Framework) (oldCfg *kubeletconfig.KubeletConfiguration) {
// Run only if the container runtime is Docker.
framework.RunIfContainerRuntimeIs("docker")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a // TODO to support container runtime generically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the TODO comment.

@derekwaynecarr
Copy link
Member

/retest

@derekwaynecarr
Copy link
Member

all tests, no new function. we can fix the TODO at a later point.

/approve no-issue

@derekwaynecarr derekwaynecarr added this to the v1.8 milestone Sep 11, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2017
@ConnorDoyle
Copy link
Contributor

/test pull-kubernetes-federation-e2e-gce

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2017
@ConnorDoyle
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorDoyle, balajismaniam, derekwaynecarr

Associated issue: 51180

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@balajismaniam
Copy link
Contributor Author

/test pull-kubernetes-federation-e2e-gce

1 similar comment
@balajismaniam
Copy link
Contributor Author

/test pull-kubernetes-federation-e2e-gce

@sjenning
Copy link
Contributor

pull-kubernetes-federation-e2e-gce is broke atm #52270

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@ConnorDoyle
Copy link
Contributor

xref kubernetes/enhancements#375

@balajismaniam
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit a63e3de into kubernetes:master Sep 12, 2017
@sjenning
Copy link
Contributor

thanks @balajismaniam 👍

@balajismaniam balajismaniam deleted the cpuman-e2e-tests branch September 12, 2017 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr derekwaynecarr left review comments

@ConnorDoyle ConnorDoyle ConnorDoyle left review comments

Assignees

@ConnorDoyle ConnorDoyle

@sjenning sjenning

@derekwaynecarr derekwaynecarr

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
10 participants
@balajismaniam @ConnorDoyle @derekwaynecarr @sjenning @k8s-github-robot @fejta-bot @lavalamp @thockin @vishh @k8s-ci-robot