Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate custom metrics API to v1beta1 #50920

Merged
merged 3 commits into from
Sep 3, 2017
Merged

Graduate custom metrics API to v1beta1 #50920

merged 3 commits into from
Sep 3, 2017

Conversation

DirectXMan12
Copy link
Contributor

@DirectXMan12 DirectXMan12 commented Aug 18, 2017 •
edited by piosz
Loading

This graduates custom-metrics.metrics.k8s.io/v1alpha1 to custom.metrics.k8s.io/v1beta1. The move is more-or-less just a straightforward rename.

Part of kubernetes/enhancements#117 and kubernetes/enhancements#118

the custom metrics API (custom.metrics.k8s.io) has moved from v1alpha1 to v1beta1

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2017
@DirectXMan12 DirectXMan12 changed the title Versions/custom metrics v2beta1 Graduate custom metrics API to v1beta1 Aug 18, 2017
@DirectXMan12
Copy link
Contributor Author

cc @kubernetes/sig-autoscaling-misc @kubernetes/sig-instrumentation-misc
cc @piosz

@k8s-ci-robot k8s-ci-robot added sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Aug 18, 2017
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 18, 2017
@DirectXMan12 DirectXMan12 force-pushed the versions/custom-metrics-v2beta1 branch from 5370f5c to 24cdabe Compare August 18, 2017 19:14
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2017
@wojtek-t
Copy link
Member

This is a bit more product decision (do we have enough knowledge to say that it's fine for beta)?
I don't have enough context to unassigning myself from that.

Once this is lgtmed be more involved people, I'm happy to approve this PR.

@wojtek-t wojtek-t assigned piosz and mwielgus and unassigned wojtek-t Aug 22, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2017
@DirectXMan12 DirectXMan12 force-pushed the versions/custom-metrics-v2beta1 branch from 24cdabe to 53101b3 Compare August 23, 2017 18:43
@piosz piosz assigned erictune and unassigned lavalamp Aug 25, 2017
@piosz
Copy link
Member

piosz commented Aug 25, 2017

@erictune could you please take a look on behalf of @kubernetes/api-approvers

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2017
@piosz
Copy link
Member

piosz commented Aug 29, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2017
@DirectXMan12 DirectXMan12 force-pushed the versions/custom-metrics-v2beta1 branch from 53101b3 to 5e8c8e5 Compare August 29, 2017 15:29
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 29, 2017
@DirectXMan12 DirectXMan12 force-pushed the versions/custom-metrics-v2beta1 branch from 5e8c8e5 to 35774f2 Compare August 29, 2017 17:11
@smarterclayton
Copy link
Contributor

/approve

On sig recognizance

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, piosz, smarterclayton

Associated issue: 117

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2017
@DirectXMan12
Copy link
Contributor Author

/retest

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2017
@DirectXMan12
Move custom metrics APIs to v1beta1
98b1a08 
This commit moves the custom metrics APIs and clients from v1alpha1
to v1beta1.
@DirectXMan12
Move HPA to use custom-metrics/v1beta1
89a56a3 
This commit migrates the HPA metrics clients to use the beta version of
the custom metrics API.
@DirectXMan12
Rename custom metrics API to custom.metrics.k8s.io
48cca6b 
This renames custom-metrics.metrics.k8s.io to custom.metrics.k8s.io,
in order to reduce stutter in the API name.
@DirectXMan12 DirectXMan12 force-pushed the versions/custom-metrics-v2beta1 branch from 35774f2 to 48cca6b Compare September 1, 2017 19:08
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2017
@calebamiles calebamiles added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2017
@calebamiles calebamiles added this to the v1.8 milestone Sep 2, 2017
@calebamiles
Copy link
Contributor

calebamiles commented Sep 2, 2017 •
edited
Loading

manually added lgtm back to the PR after rebase and moved into the 1.8 milestone due to initial lgtm being received before code freeze

cc: @kubernetes/kubernetes-release-managers

@smarterclayton
Copy link
Contributor

Pre ship the group needs to be renamed to custom.metrics.k8s.io, I expect that to be covered in the metrics to v1beta1 PR. Please link here

@calebamiles
Copy link
Contributor

calebamiles commented Sep 2, 2017 •
edited
Loading

but nothing to do with this PR besides cross linking to the other PR correct, @smarterclayton?

@CaoShuFeng
Copy link
Contributor

/test pull-kubernetes-verify

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-ci-robot
Copy link
Contributor

@DirectXMan12: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 48cca6b link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 51335, 51364, 51130, 48075, 50920)

@k8s-github-robot k8s-github-robot merged commit d375e15 into kubernetes:master Sep 3, 2017
@piosz
Copy link
Member

piosz commented Sep 5, 2017

I changed the api group in release notes.

@DirectXMan12 DirectXMan12 deleted the versions/custom-metrics-v2beta1 branch September 5, 2017 13:08
@smarterclayton
Copy link
Contributor

but nothing to do with this PR besides cross linking to the other PR correct

Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erictune erictune

@piosz piosz

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.