Convert resource-quota and rethinkdb to v1beta3 #5079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| **Features** | ||
|
|
||
| * Auto configuration cluster by querying info from k8s |
There was a problem hiding this comment.
Should read "Auto-configuration of a cluster..."
|
@quinton-hoole the issues you pointed out above are existing in the original v1beta1 / v1beta2 example. I just simply copied README and yaml/json files over to v1beta3 directory. I did notice some of those problems you pointed out here, but mind to send a separate pr for those? |
| rethinkdb-driver db=influxdb db=rethinkdb 10.241.105.47 28015 | ||
| ``` | ||
|
|
||
| open a web browser and access to *http://10.241.220.209:8080* to manage you cluster |
There was a problem hiding this comment.
Capitalize this sentence please: "Open a web browser..."
|
@dchen1107 Sure, I can do that. More comments once I've had a chance to test out the yaml files. |
|
ping... |
|
LGTM |
bgrant0607
added a commit
that referenced
this pull request
Mar 10, 2015
Convert resource-quota and rethinkdb to v1beta3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3671