Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on legacy kubernetes_auth file to kubeconfig-file.md #5071

Merged
merged 1 commit into from
Mar 6, 2015

Conversation

j3ffml
Copy link
Contributor

@j3ffml j3ffml commented Mar 4, 2015

Closes #3869. cc @deads2k

"Insecure": false
}
```
All entries are optional. `User`, `Password`, `CertFile`, `KeyFile`, and `BearerToken` are applied to the kubectl user. `CAFile` and `Insecure` apply to the cluster. The same rules regarding one authentication technique apply as for .kubeconfig entries (see below).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validateAuthInfo doesn't detect conflicting BearerToken and User authentication loaded from --auth-path: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/client/clientcmd/validation.go#L139

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed wording to warn against setting both.

@erictune erictune self-assigned this Mar 5, 2015
@erictune
Copy link
Member

erictune commented Mar 5, 2015

I'll merge this once @deads2k gives the LGTM

@j3ffml
Copy link
Contributor Author

j3ffml commented Mar 5, 2015

PTAL

@deads2k
Copy link
Contributor

deads2k commented Mar 5, 2015

lgtm

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2015
brendandburns added a commit that referenced this pull request Mar 6, 2015
Add documentation on legacy kubernetes_auth file to kubeconfig-file.md
@brendandburns brendandburns merged commit ea7c54e into kubernetes:master Mar 6, 2015
@j3ffml j3ffml deleted the docs branch March 9, 2015 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes_auth missing documentation
5 participants