Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move autoscaling/v2 from alpha1 to beta1 #50708

Merged
merged 2 commits into from
Sep 6, 2017
Merged

Move autoscaling/v2 from alpha1 to beta1 #50708

merged 2 commits into from
Sep 6, 2017

Conversation

DirectXMan12
Copy link
Contributor

@DirectXMan12 DirectXMan12 commented Aug 15, 2017 •
edited
Loading

This graduates autoscaling/v2alpha1 to autoscaling/v2beta1. The move is more-or-less just a straightforward rename.

Part of kubernetes/enhancements#117

v2 of the autoscaling API group, including improvements to the HorizontalPodAutoscaler, has moved from alpha1 to beta1.

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 15, 2017
@DirectXMan12 DirectXMan12 force-pushed the versions/autoscaling-v2beta1 branch from 3ea453f to 6f658a2 Compare August 15, 2017 19:22
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2017
@mwielgus
Copy link
Contributor

Does this PR also enable the api by default?

@DirectXMan12
Copy link
Contributor Author

Does this PR also enable the api by default?

No, I haven't changed whether it's enabled by default or not. Good catch, I'll fix that once I fix some of the verification errors.

@sttts
Copy link
Contributor

sttts commented Aug 16, 2017

Storage version is v1, so this change is fine. kubectl also uses v1 I guess. So only those clients explicitly opting in will miss the v2alpha1 group with this hard cut. So looks good to me.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2017
@DirectXMan12 DirectXMan12 force-pushed the versions/autoscaling-v2beta1 branch from 325abae to 7a30a53 Compare August 17, 2017 17:37
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2017
@DirectXMan12
Copy link
Contributor Author

Dearest verify-api-reference-doc,

Have you been drinking? ./hack/update-api-reference-docs.sh makes no changes, yet you still complain.

Sincerely,
Solly

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2017
@DirectXMan12 DirectXMan12 force-pushed the versions/autoscaling-v2beta1 branch from 7a30a53 to 1b74f67 Compare August 18, 2017 14:58
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2017
@DirectXMan12
Copy link
Contributor Author

@sttts any idea what's going on with verify?

@sttts
Copy link
Contributor

sttts commented Aug 21, 2017

@sttts any idea what's going on with verify?

You just forgot to update api docs?

@sttts
Copy link
Contributor

sttts commented Aug 21, 2017

Have you been drinking? ./hack/update-api-reference-docs.sh makes no changes, yet you still complain.

looks like you did think about it. Hmm.

@DirectXMan12
Copy link
Contributor Author

@sttts yeah, I can't get update-api-reference-docs to produce any changes, but verify-api-reference-docs insists v1alpha1 existing. It's almost like it's using an old version of the container image to verify.

@sttts
Copy link
Contributor

sttts commented Aug 21, 2017

Stupid question: make clean?

@sttts
Copy link
Contributor

sttts commented Aug 21, 2017

@DirectXMan12 don't know much about the *-api-reference-docs scripts either. I fear you have to debug them to know what's going on :-/

@piosz
Copy link
Member

piosz commented Aug 22, 2017

cc @kubernetes/sig-autoscaling-api-reviews

@k8s-ci-robot k8s-ci-robot added sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Aug 22, 2017
@DirectXMan12 DirectXMan12 force-pushed the versions/autoscaling-v2beta1 branch from 1b74f67 to 6e0b77d Compare August 24, 2017 20:03
@smarterclayton
Copy link
Contributor

Changes look good to me, but will defer to the sig.

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2017
@DirectXMan12
Copy link
Contributor Author

/retest

@DirectXMan12
Copy link
Contributor Author

/retest

@piosz @kubernetes/sig-instrumentation-bugs there are what seem like a bunch of flakes on Stackdriver logging. Can one of you take a look and make sure it's not some actual error?

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. kind/bug Categorizes issue or PR as related to a bug. labels Aug 31, 2017
@DirectXMan12
Copy link
Contributor Author

looks like it's related to #51700

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2017
@DirectXMan12 DirectXMan12 force-pushed the versions/autoscaling-v2beta1 branch from c32900e to a0d58f7 Compare September 1, 2017 20:17
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2017
@smarterclayton
Copy link
Contributor

/retest

1 similar comment
@sjenning
Copy link
Contributor

sjenning commented Sep 2, 2017

/retest

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2017
@DirectXMan12
Move Autoscaling v2{alpha1 --> beta1}
b0af402 
This commit renames autoscaling/v2alpha1 to autoscaling/v2beta1.
Only the API-related code is moved in this commit.
@DirectXMan12
Move consumers of autoscaling/v2alpha1 to v2beta1
c8690f3 
This commit updates consumers (mainly the HPA controller, but also the
kubectl printers) of autoscaling/v2alpha1 to autoscaling/v2beta1.
@DirectXMan12 DirectXMan12 force-pushed the versions/autoscaling-v2beta1 branch from a0d58f7 to c8690f3 Compare September 5, 2017 21:49
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 5, 2017 •
edited
Loading

@DirectXMan12: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel 6b3c6e8155c40336c2db77f8f2a15c9e439e16ee link /test pull-kubernetes-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sjenning
Copy link
Contributor

sjenning commented Sep 6, 2017

cross failure is fixed in #51984

@sttts
Copy link
Contributor

sttts commented Sep 6, 2017

/retest

@derekwaynecarr
Copy link
Member

adding to 1.8 milestone per feature freeze exception being granted.

/cc @jdumars

@k8s-ci-robot k8s-ci-robot requested a review from jdumars September 6, 2017 19:40
@derekwaynecarr derekwaynecarr added this to the v1.8 milestone Sep 6, 2017
@sjenning
Copy link
Contributor

sjenning commented Sep 6, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, sjenning, smarterclayton

Associated issue: 117

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 51956, 50708)

@k8s-github-robot k8s-github-robot merged commit 3168bd4 into kubernetes:master Sep 6, 2017
@DirectXMan12 DirectXMan12 deleted the versions/autoscaling-v2beta1 branch September 7, 2017 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdumars jdumars Awaiting requested review from jdumars

Assignees

@sjenning sjenning

@sttts sttts

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
10 participants
@DirectXMan12 @mwielgus @sttts @piosz @smarterclayton @sjenning @k8s-ci-robot @derekwaynecarr @k8s-github-robot @timothysc