Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure - Use cloud environment to instantiate storage client #50673

Merged
merged 2 commits into from
Sep 23, 2017
Merged

Azure - Use cloud environment to instantiate storage client #50673

merged 2 commits into from
Sep 23, 2017

Conversation

clement-buchart
Copy link
Contributor

@clement-buchart clement-buchart commented Aug 15, 2017 •
edited by wojtek-t
Loading

What this PR does / why we need it:
Since 1.7 and managed disk for azure, blob storage on Azure cloud other than the default public one is broken, because kubernetes expect blob ressources URI to end with .blob.core.windows.net (ignoring storageEndpointSuffix).
This include the chinese Cloud, for which storageEndpointSuffix is blob.core.chinacloudapi.cn for example.

See : https://github.com/Azure/azure-storage-go/blob/master/client.go#L194

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Support German cloud for azure disk mount feature

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 15, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @clement-buchart. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 15, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Aug 15, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 15, 2017
@dims
Copy link
Member

dims commented Aug 17, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2017
@k8s-github-robot
Copy link

Adding do-not-merge/release-note-label-needed because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-action-required", "release-note-experimental" or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

@k8s-github-robot k8s-github-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-label-needed labels Aug 30, 2017
@clement-buchart clement-buchart changed the title Use cloud environment to instantiate client Azure - Use cloud environment to instantiate client Sep 5, 2017
@clement-buchart clement-buchart changed the title Azure - Use cloud environment to instantiate client Azure - Use cloud environment to instantiate storage client Sep 5, 2017
@clement-buchart
Copy link
Contributor Author

@dims Anything I am supposed to do to get this moving forward ?

Thanks :)

@dims
Copy link
Member

dims commented Sep 15, 2017

/retest

@dims
Copy link
Member

dims commented Sep 15, 2017

/assign @brendandburns

@dims
Copy link
Member

dims commented Sep 15, 2017

/test all

@dims
Copy link
Member

dims commented Sep 15, 2017

@clement-buchart things not marked 1.8 are mostly ignored right now. you will need reviews/approval from folks in the OWNERS file. some of them may not be using github notifications, so try slack or ask in the team meeting would be my suggestion

@brendandburns
Copy link
Contributor

/retest
/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, clement-buchart

Associated issue requirement bypassed by: brendandburns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 52355, 52537, 52551, 52403, 50673). If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit 4e64a3b into kubernetes:master Sep 23, 2017
@andyzhangx
Copy link
Member

andyzhangx commented Sep 24, 2017 •
edited
Loading

hi @clement-buchart we are fixing the same bug, and your PR get merged first. :) This PR should cherry-pick to v1.7, will you do that or shall I help you? Thanks.
I will close mine: #52878

This was referenced Sep 24, 2017
Closed
Closed
@clement-buchart clement-buchart mentioned this pull request Sep 25, 2017
Merged
@clement-buchart
Copy link
Contributor Author

Here you go : #52962

But this this PR doesn't have a milestone, nor the cherrypick-candidate label, so I'm not sure how this is going to play out.

@liggitt liggitt mentioned this pull request Sep 27, 2017
Closed
@ITler
Copy link

ITler commented Sep 28, 2017 •
edited
Loading

@andyzhangx May I kindly ask you to cherry pick this PR to next 1.7 release as this seems to be the remaining open point to get this merge into action? Thank you

@andyzhangx
Copy link
Member

andyzhangx commented Sep 28, 2017 •
edited
Loading

@ITler there is already a cherry pick PR #52962 for 1.7

@wojtek-t wojtek-t added this to the v1.7 milestone Oct 16, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 17, 2017
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 17, 2017
k8s-github-robot pushed a commit that referenced this pull request Oct 17, 2017
Merge pull request #52962 from clement-buchart/automated-cherry-pick-…
7da1b98 
…of-#50673-origin-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #50673

Cherry pick of #50673 on release-1.7.

#50673: Use cloud environment to instantiate client
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@andyzhangx andyzhangx mentioned this pull request Oct 26, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 1, 2017
Merge pull request #54615 from andyzhangx/automated-cherry-pick-of-#5…
cf3117c 
…0673-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #50673

Cherry pick of #50673 on release-1.8.

#50673: Support German cloud for azure disk mount feature

**Release note**:

```
Support German cloud for azure disk mount feature
```
andyzhangx added a commit to andyzhangx/kubernetes that referenced this pull request Nov 7, 2017
@andyzhangx
merge kubernetes#50673: azure disk fix of SovereignCloud support
7698538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krousey krousey

@brendandburns brendandburns

@satnam6502 satnam6502

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.