Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables the v1beta2 version of the apps API group by default #50643

Merged
merged 2 commits into from
Aug 17, 2017
Merged

Enables the v1beta2 version of the apps API group by default #50643

merged 2 commits into from
Aug 17, 2017

Conversation

kow3ns
Copy link
Member

@kow3ns kow3ns commented Aug 14, 2017

What this PR does / why we need it: Enables the v1beta2 version of the apps API group by default

fixes # #50641

apps/v1beta2 is enabled by default. DaemonSet, Deployment, ReplicaSet, and StatefulSet have been moved to this group version.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2017
@kow3ns kow3ns requested a review from caesarxuchao August 14, 2017 22:00
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 14, 2017
@kow3ns
Copy link
Member Author

kow3ns commented Aug 14, 2017

/retest

@crimsonfaith91
Copy link
Contributor

crimsonfaith91 commented Aug 16, 2017 •
edited
Loading

/lgtm
Everything looks good to me.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@kow3ns
Copy link
Member Author

kow3ns commented Aug 16, 2017

@bgrant0607 @smarterclayton

@liyinan926 liyinan926 mentioned this pull request Aug 16, 2017
Merged
@kow3ns kow3ns force-pushed the enableappsv1beta2 branch from a472993 to 8a466ec Compare August 16, 2017 19:30
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@crimsonfaith91
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@crimsonfaith91
Copy link
Contributor

/retest

1 similar comment
@kow3ns
Copy link
Member Author

kow3ns commented Aug 16, 2017

/retest

@bgrant0607
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, crimsonfaith91, kow3ns

Associated issue: 50641

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2017
@crimsonfaith91
Copy link
Contributor

/retest

1 similar comment
@crimsonfaith91
Copy link
Contributor

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 427d763 into kubernetes:master Aug 17, 2017
@janetkuo janetkuo mentioned this pull request Aug 22, 2017
Closed
@hzxuzhonghu hzxuzhonghu mentioned this pull request Nov 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@bgrant0607 bgrant0607

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kow3ns @crimsonfaith91 @bgrant0607 @k8s-github-robot @justinsb @mwielgus @k8s-ci-robot