Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated gce-pd and redis examples to use v1beta3 #5062

Merged
merged 1 commit into from
Mar 12, 2015
Merged

Updated gce-pd and redis examples to use v1beta3 #5062

merged 1 commit into from
Mar 12, 2015

Conversation

ArtfulCoder
Copy link
Contributor

updated gce-pd and redis examples to use v1beta3
#3671

@bgrant0607
@lavalamp

sub-mod
sub-mod reviewed Mar 4, 2015
View reviewed changes
examples/redis/v1beta3/redis-sentinel-controller.yaml
name: sentinel
ports:
- containerPort: 26379
name: api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last i heard we were removing named ports

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please remove the name.

@bgrant0607 bgrant0607 self-assigned this Mar 4, 2015
bgrant0607
bgrant0607 reviewed Mar 4, 2015
View reviewed changes
examples/redis/v1beta3/image/redis-master.conf
@@ -0,0 +1,827 @@
# Redis configuration file example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these .conf files are identical to the v1beta1 versions, I'm inclined to not copy them. Just reuse the existing ones.

@ArtfulCoder ArtfulCoder force-pushed the doc branch 6 times, most recently from e252c29 to 6a798e1 Compare March 5, 2015 20:07
@ArtfulCoder
Copy link
Contributor Author

PTAL @bgrant0607

bgrant0607
bgrant0607 reviewed Mar 5, 2015
View reviewed changes
examples/redis/v1beta3/redis-slave.yaml
@@ -0,0 +1,21 @@
apiVersion: v1beta3
kind: Pod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should delete this file. They should be using the replication controller now.

@ArtfulCoder
Copy link
Contributor Author

All pods are created through replication controllers now.
Updated the command to use "kubectl stop rc redis-master".

PTAL @bgrant0607

@bgrant0607
Copy link
Member

@ArtfulCoder Did you decide that it was ok to convert all the pods to replication controllers?

@ArtfulCoder ArtfulCoder force-pushed the doc branch 2 times, most recently from 0763c9d to 8f8d6e9 Compare March 11, 2015 21:31
@ArtfulCoder
Copy link
Contributor Author

@bgrant0607 PTAL at the changes.

@bgrant0607
Copy link
Member

Great! LGTM.

@bgrant0607
Copy link
Member

You deleted a file used outside the example:

valid-pod
F0311 21:40:40.301610   19097 create.go:50] Client error processing command: the path "examples/redis/redis-proxy.yaml" does not exist
!!! Error in ./hack/test-cmd.sh:240
  'kubectl create -f examples/redis/redis-proxy.yaml "${kube_flags[@]}"' exited with status 255
Call stack:
  1: ./hack/test-cmd.sh:240 main(...)

@ArtfulCoder
Copy link
Contributor Author

@bgrant0607 PTAL
All checks are passing now.

bgrant0607 added a commit that referenced this pull request Mar 12, 2015
@bgrant0607
Merge pull request #5062 from ArtfulCoder/doc
c0b8dc5 
Updated gce-pd and redis examples to use v1beta3
@bgrant0607 bgrant0607 merged commit c0b8dc5 into kubernetes:master Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArtfulCoder @bgrant0607 @vishh @sub-mod @googlebot