Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support fieldSelector spec.schedulerName #50582

Merged
merged 1 commit into from
Aug 26, 2017
Merged

support fieldSelector spec.schedulerName #50582

merged 1 commit into from
Aug 26, 2017
+17 −1

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Aug 14, 2017

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49190

Special notes for your reviewer:
/assign @davidopp @bsalamat
/cc @lavalamp

Release note:

add fieldSelector spec.schedulerName

@k8s-ci-robot k8s-ci-robot requested a review from lavalamp August 14, 2017 01:53
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 14, 2017
@dixudx
Copy link
Member Author

dixudx commented Aug 14, 2017

@ravisantoshgudimetla @shivramsrivastava PTAL. Thanks.

@dixudx
Copy link
Member Author

dixudx commented Aug 14, 2017

/assign @davidopp @bsalamat
I think it's ready for review. PTAL. Thanks.

@wojtek-t
Copy link
Member

/ok-to-test

/approve no-issue

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2017
@dixudx
Copy link
Member Author

dixudx commented Aug 14, 2017

ping @wojtek-t Need your lgtm. Thanks.

@ravisantoshgudimetla
Copy link
Contributor

ravisantoshgudimetla commented Aug 14, 2017 •
edited
Loading

I think there is no validation for this field. @dixudx Do you mind adding some validation to schedulerName field or do you want to handle it in a separate PR?

@dixudx
Copy link
Member Author

dixudx commented Aug 15, 2017

@ravisantoshgudimetla I think we'd better handle it in a separate PR, since the validation for schedulerName is another scope. I'll open a new PR to take this part.

@dixudx
Copy link
Member Author

dixudx commented Aug 17, 2017

ping @caesarxuchao @davidopp Need your /lgtm to get it merged. PTAL. Thanks.

@dixudx dixudx force-pushed the support_fieldSelector_spec.schedulerName branch from 9384f6f to 58669f6 Compare August 18, 2017 05:32
@dixudx
Copy link
Member Author

dixudx commented Aug 18, 2017

ping @caesarxuchao @davidopp @wojtek-t

Need your /lgtm to get it merged. PTAL. Thanks.

@caesarxuchao
Copy link
Member

lgtm. @liggitt @deads2k could you also take a look? Thanks.

@liggitt
Copy link
Member

liggitt commented Aug 25, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, liggitt, wojtek-t

Associated issue: 49190

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Aug 25, 2017

lgtm. @liggitt @deads2k could you also take a look? Thanks.

looks fine.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@dixudx
Copy link
Member Author

dixudx commented Aug 26, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50889, 51347, 50582, 51297, 51264)

@k8s-github-robot k8s-github-robot merged commit 6650bbe into kubernetes:master Aug 26, 2017
@dixudx dixudx deleted the support_fieldSelector_spec.schedulerName branch August 26, 2017 05:45
@mkumatag mkumatag mentioned this pull request Sep 8, 2017
Closed
@k82cn k82cn mentioned this pull request Sep 11, 2017
Closed
@dixudx dixudx mentioned this pull request Sep 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

@caesarxuchao caesarxuchao

@davidopp davidopp

@wojtek-t wojtek-t

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

field label spec.schedulerName not supported