Add v1beta3 files to update-demo #5051
Merged
+50
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll also need to update the e2e test that runs through this example since you're changing the file location. See https://github.com/GoogleCloudPlatform/kubernetes/blob/master/test/e2e/kubectl.go#L47 |
| version: kitten | ||
| spec: | ||
| containers: | ||
| - capabilities: {} |
There was a problem hiding this comment.
Please remove the capabilities. This example doesn't need them.
lavalamp
force-pushed
the
fix6
branch
2 times, most recently
from
ff6ea8e to
ebd0f28
Compare
|
Fixed, PTAL. I ran that e2e test to verify that it still runs. |
|
LGTM. Will merge once travis completes. |
bgrant0607
added
the
lgtm
|
I think the example test is no longer passing, I'll fix later. |
lavalamp
removed
the
lgtm
|
Fixed, PTAL |
|
LGTM |
bgrant0607
added
the
lgtm
bgrant0607
added a commit
that referenced
this pull request
Mar 5, 2015
Add v1beta3 files to update-demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hesitate to start actually talking about v1beta3 in the README since this is supposed to be an example for a complete beginner.