Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy annotations from StatefulSet to owned ControllerRevisions #50263

Merged
merged 2 commits into from
Aug 9, 2017
Merged

Copy annotations from StatefulSet to owned ControllerRevisions #50263

merged 2 commits into from
Aug 9, 2017

Conversation

liyinan926
Copy link
Contributor

@liyinan926 liyinan926 commented Aug 7, 2017 •
edited
Loading

What this PR does / why we need it:
This PR starts copying annotations from a StatefulSet's metadata to the ControllerRevisions it owns. DaemonSet controller copies the annotations from a DaemonSets metadata to the ControllerRevisions it owns. One of the annotation copied is kubernetes.io/change-cause, which is used in DaemonSetHistoryViewer to fill in the CHANGE-CAUSE column of revision history of a DaemonSet.

For consistency, the StatefulSet controller should do the same, i.e., copy annotations in a StatefulSet's metadata to the ControllerRevisions it owns for consistency.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #50158.

Special notes for your reviewer:
/assign @kow3ns

Release note:

Copy annotations from a StatefulSet's metadata to the ControllerRevisions it owns

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @liyinan926. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 7, 2017
@kow3ns
Copy link
Member

kow3ns commented Aug 7, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2017
@liyinan926 liyinan926 changed the title Copy change-cause annotation from StatefulSet to owned ControllerRevisions Copy annotations from StatefulSet to owned ControllerRevisions Aug 7, 2017
@liyinan926
Copy link
Contributor Author

/retest

@liyinan926
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-etcd3

@liyinan926
Copy link
Contributor Author

@kow3ns need a lgtm label. Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2017
@liyinan926
Copy link
Contributor Author

@kow3ns Now need your approval again after the lgtm was added. Thanks!

@kow3ns
Copy link
Member

kow3ns commented Aug 8, 2017

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2017
@liyinan926
Copy link
Contributor Author

/test pull-kubernetes-federation-e2e-gce

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2017
@crimsonfaith91
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crimsonfaith91, kow3ns, liyinan926

Associated issue: 50158

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@liyinan926
Copy link
Contributor Author

/test pull-kubernetes-bazel

@liyinan926
Copy link
Contributor Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50173, 50324, 50288, 50263, 50333)

@k8s-github-robot k8s-github-robot merged commit 8f5f061 into kubernetes:master Aug 9, 2017
dims pushed a commit to dims/kubernetes that referenced this pull request Feb 8, 2018
Merge pull request kubernetes#50263 from liyinan926/branch1
a212b8d 
Automatic merge from submit-queue (batch tested with PRs 50173, 50324, 50288, 50263, 50333)

Copy annotations from StatefulSet to owned ControllerRevisions

**What this PR does / why we need it**:
This PR starts copying annotations from a `StatefulSet`'s metadata to the `ControllerRevision`s it owns. `DaemonSet` controller copies the annotations from a `DaemonSet`s metadata to the `ControllerRevision`s it owns. One of the annotation copied is `kubernetes.io/change-cause`, which is used in `DaemonSetHistoryViewer` to fill in the `CHANGE-CAUSE` column of revision history of a `DaemonSet`.

For consistency, the `StatefulSet` controller should do the same, i.e., copy annotations in a `StatefulSet`'s metadata to the `ControllerRevision`s it owns for consistency. 

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes#50158.

**Special notes for your reviewer**:
/assign @kow3ns 

**Release note**:
```release-note
Copy annotations from a StatefulSet's metadata to the ControllerRevisions it owns
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kow3ns kow3ns kow3ns approved these changes

Assignees

@kow3ns kow3ns

@crimsonfaith91 crimsonfaith91

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DaemonSet and StatefulSet controllers should be consistent in annotation propagation to ControllerRevisions
5 participants
@liyinan926 @k8s-ci-robot @kow3ns @crimsonfaith91 @k8s-github-robot