Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable selfHosted feature flag #50241

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Enable selfHosted feature flag #50241

merged 1 commit into from
Aug 7, 2017

Conversation

jamiehannaford
Copy link
Contributor

What this PR does / why we need it:

Enables feature gating for self-hosting on kubeadm

Which issue this PR fixes

Continuation of kubernetes/kubeadm#323

Release note:

Feature gates now determine whether a cluster is self-hosted. For more information, see the FeatureGates configuration flag.

/cc @luxas

@k8s-ci-robot k8s-ci-robot requested a review from luxas August 7, 2017 09:36
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @jamiehannaford. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 7, 2017
luxas
luxas approved these changes Aug 7, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@luxas
Copy link
Member

luxas commented Aug 7, 2017

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2017
@luxas
Copy link
Member

luxas commented Aug 7, 2017 

I0807 12:35:12.417] cmd/kubeadm/app/cmd/init.go:288: cannot use i.cfg.FeatureFlags (type map[string]bool) as type features.FeatureList in argument to features.Enabled
I0807 12:35:12.418] cmd/kubeadm/app/cmd/init.go:288: cannot use features.SelfHosting (type feature.Feature) as type string in argument to features.Enabled

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2017
@luxas
Copy link
Member

luxas commented Aug 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jamiehannaford, luxas

Associated issue: 323

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50087, 39587, 50042, 50241, 49914)

@k8s-github-robot k8s-github-robot merged commit 8c22b11 into kubernetes:master Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

Assignees

@errordeveloper errordeveloper

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jamiehannaford @k8s-ci-robot @luxas @k8s-github-robot @errordeveloper