Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add field selector for kubectl get #50140

Merged
merged 3 commits into from
Nov 7, 2017
Merged

add field selector for kubectl get #50140

merged 3 commits into from
Nov 7, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Aug 4, 2017

What this PR does / why we need it:
When working in #50075, I found current kubectl did not support using field-selector.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #14129

Special notes for your reviewer:
/cc @janetkuo @Kargakis
/assign @derekwaynecarr @smarterclayton @bgrant0607

Release note:

add field selector for kubectl get

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 4, 2017
@dims
Copy link
Member

dims commented Aug 4, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 4, 2017
@dixudx dixudx force-pushed the kubectl_add_fieldSelector branch 3 times, most recently from c9dfab9 to 04d4a90 Compare August 5, 2017 08:42
@dixudx
Copy link
Member Author

dixudx commented Aug 5, 2017

/retest

@dixudx
Copy link
Member Author

dixudx commented Aug 8, 2017

/assign @dchen1107 @thockin

@bgrant0607
Copy link
Member

@dixudx
Release-note guidance: kubernetes/community#484

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 6, 2017
@smarterclayton
Copy link
Contributor

Looking pretty good to me. Can you squash the non-moves into a smaller set of commits?

@dixudx dixudx force-pushed the kubectl_add_fieldSelector branch from 975c549 to 1fff851 Compare November 6, 2017 06:22
@dixudx dixudx force-pushed the kubectl_add_fieldSelector branch from 1fff851 to d3759b9 Compare November 6, 2017 06:31
@dixudx
Copy link
Member Author

dixudx commented Nov 6, 2017

@smarterclayton Squashed. PTAL. Thanks so much for your comments and reviews.

@dixudx dixudx force-pushed the kubectl_add_fieldSelector branch 2 times, most recently from 7380cc4 to 48c920e Compare November 6, 2017 07:50
@dixudx dixudx force-pushed the kubectl_add_fieldSelector branch from 48c920e to fa143c6 Compare November 6, 2017 09:27
@dixudx
Copy link
Member Author

dixudx commented Nov 7, 2017

/assign @liggitt @smarterclayton

@smarterclayton
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, smarterclayton

Associated issue: 50075

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 53273, 55058, 55237, 50140). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 45bdf70 into kubernetes:master Nov 7, 2017
@dixudx dixudx deleted the kubectl_add_fieldSelector branch November 8, 2017 01:57
@dixudx dixudx mentioned this pull request Nov 14, 2017
Merged
@dixudx dixudx mentioned this pull request Nov 24, 2017
Open
@jlamillan
Copy link

Is this in a release yet?

@dixudx
Copy link
Member Author

dixudx commented Dec 5, 2017

@jlamillan Will be released together with v1.9.

@sttts @wojtek-t Add to milestone release-1.9?

@liggitt liggitt added this to the v1.9 milestone Dec 5, 2017
@tiewei tiewei mentioned this pull request Dec 5, 2017
Merged
@zflamig zflamig mentioned this pull request Jul 6, 2018
Merged
@jamesrgrinter jamesrgrinter mentioned this pull request Aug 16, 2019
Closed
@tnqn tnqn mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiywang shiywang shiywang left review comments

@0xmichalis 0xmichalis 0xmichalis left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@liggitt liggitt liggitt left review comments

@janetkuo janetkuo Awaiting requested review from janetkuo

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Unable to use kubectl get with a fieldSelector