Copy download-or-bust helper from gce to aws #5014
Merged
+64
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spotted the |
roberthbailey
added
the
lgtm
|
I'd fix the helper function in this PR. |
|
OK - thanks: Fixed the message in the helper function as well. |
| @@ -0,0 +1,29 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Copyright 2014 Google Inc. All rights reserved. | |||
|
Couple of nits; otherwise LGTM. |
justinsb
force-pushed
the
aws_cluster_push
branch
from
e1ea065 to
758eed6
Compare
|
Don't merge yet ... I somehow touched the previous commit during my squash |
During a push, we were wget-ing to <filename>.1, .2, etc, which wasn't working
justinsb
force-pushed
the
aws_cluster_push
branch
from
758eed6 to
05d4aea
Compare
|
OK, fixed up the git problems. Sorry about that. I made the proposed changes: fixed the copyright and removed the commented out detect-project. |
|
LGTM. |
|
Waiting for travis to pass before merging. |
|
Poking travis again.... |
roberthbailey
added a commit
that referenced
this pull request
Mar 5, 2015
Copy download-or-bust helper from gce to aws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a push, we were wget-ing to .1, .2, etc, which wasn't working