Small cleanups to a number of client behaviors #5013
Conversation
Also fix that Update was returning AlreadyExists instead of NotFound (when create is disabled) and that Update when CreateOnUpdate was true was not populating the returned object. Added more tests
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
Ensures that all objects can be printed, even if they don't match output-version (because they are only implemented in a newer API version).
Some types will be looked up based on their internal type, which is passed directly to RESTMapping(). RESTMapping() will search the entire version list if no external types are passed, but OutputVersionMapper was bypassing that because the default type was always present. Change OutputVersionMapper to collapse empty versions, and when no external type is specified, try with the preferred version and then try without.
smarterclayton
force-pushed
the
misc_fixup
branch
from
13e959f to
17f7dd8
Compare
| @@ -327,11 +356,15 @@ func (e *Etcd) Delete(ctx api.Context, name string) (runtime.Object, error) { | |||
| return &api.Status{Status: api.StatusSuccess}, nil | |||
| } | |||
|
|
|||
| // Watch starts a watch for the items that m matches. | |||
| // WatchPredicate starts a watch for the items that m matches. | |||
|
LGTM. Nit is not a big deal. Should I ask for an e2e run, though? I think it's probably ok? |
|
I'll do an e2e. It's somewhat big ----- Original Message -----
|
|
Are you able to kick off an automated e2e on pulls through jenkins? i'm having problems with my local e2e setup for some reason. ----- Original Message -----
|
|
Running e2e |
|
OK guestbook failed for me but I'm pretty sure it's because of previous bad state in my e2e cluster. LGTM |
lavalamp
added
the
lgtm
Small cleanups to a number of client behaviors
This is extracted from #5012 and contains small fixes and cleanups. The most
significant changes are allowing kubectl to properly handle objects that don't
exist in v1beta1/v1beta2