Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed un-used InodePressure condition. #50124

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Removed un-used InodePressure condition. #50124

merged 1 commit into from
Aug 8, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Aug 4, 2017

What this PR does / why we need it:
Removed un-used InodePressure condition; kubelet did not report it anymore, so remove it.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49103

Release note:

The node condition 'NodeInodePressure' was removed, as kubelet did not report it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2017
@k82cn
Copy link
Member Author

k82cn commented Aug 4, 2017

@kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 4, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 4, 2017
@k82cn
Copy link
Member Author

k82cn commented Aug 4, 2017

@k8s-mirror-api-machinery-pr-reviews

@dashpole
Copy link
Contributor

dashpole commented Aug 7, 2017

/lgtm
For background: InodePressure was added and then removed from the non-versioned API (pkg/api/types.go) within a release (no release had this condition). However, during the time that it was in the non-versioned API, this was copied into the versioned API. This condition has never been reported by the kubelet in any release, and should be safe to remove.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2017
@k82cn
Copy link
Member Author

k82cn commented Aug 7, 2017

/assign @mikedanese @thockin

would you help to approve that ?

@k82cn
Copy link
Member Author

k82cn commented Aug 8, 2017

cc/ @gmarek @yastij

@k82cn k82cn mentioned this pull request Aug 8, 2017
Merged
@thockin
Copy link
Member

thockin commented Aug 8, 2017

/lgtm
/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, k82cn, thockin

Associated issue: 49103

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3900e36 into kubernetes:master Aug 8, 2017
@k82cn k82cn deleted the k8s_49103 branch August 8, 2017 04:38
@k82cn k82cn mentioned this pull request Aug 8, 2017
Merged
@gmarek
Copy link
Contributor

gmarek commented Aug 8, 2017

@k82cn - thanks for doing that.

@k82cn k82cn mentioned this pull request Aug 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timothysc timothysc

@mikedanese mikedanese

@dashpole dashpole

@thockin thockin

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated NodeInodePressure condition?
9 participants
@k82cn @dashpole @thockin @k8s-github-robot @gmarek @timothysc @mikedanese @saad-ali @k8s-ci-robot