Pod templates as their own type #5012

smarterclayton · 2015-03-04T04:05:13Z

This pull request adds pod templates as their own type (first step towards #170). Having
a distinct type allows their use to be clearly delineated for end users, to have their
own independent validation rules, and to simplify interactions from the client. This does
not prevent pods from having "inert" behavior in the future that can also be used for
templates. Replication controllers should work against inert pods or pod templates equally.

Only the last commit is new - the others are issues found while trying to support a
type that only exists in v1beta3.

googlebot · 2015-03-04T04:05:15Z

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

pmorie · 2015-03-04T04:15:52Z

@liggitt since we were just talking about this
On Tue, Mar 3, 2015 at 11:05 PM Clayton Coleman notifications@github.com
wrote:

This pull request adds pod templates as their own type (first step towards
#170 #170).
Having
a distinct type allows their use to be clearly delineated for end users,
to have their
own independent validation rules, and to simplify interactions from the
client. This does
not prevent pods from having "inert" behavior in the future that can also
be used for
templates. Replication controllers should work against inert pods or pod
templates equally.

Only the last commit is new - the others are issues found while trying to
support a

type that only exists in v1beta3.

You can view, comment on, or merge this pull request online at:

#5012
Commit Summary

genericetcd.Etcd should test resourceVersion

Stop round trip testing in latest

Skip types that are not registered on an API version

Stop logging stack traces for 4xx requests

Switch List/Watch to ListPredicate/WatchPredicate

Enumerate all versions when looking for an output conversion

Use IsListType instead of checking ItemPtr in resourcebuilder

Pod Templates

Only insert outputversion as a preferred mapping type if no error
occurs

File Changes

A api/examples/podtemplate.json
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-0
(22)

M examples/examples_test.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-1
(9)

M hack/test-cmd.sh
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-2
(28)

M pkg/api/latest/latest_test.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-3
(48)

M pkg/api/register.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-4
(4)

M pkg/api/rest/resttest/resttest.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-5
(27)

M pkg/api/serialization_test.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-6
(23)

M pkg/api/validation/validation.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-7
(18)

M pkg/apiserver/api_installer.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-8
(4)

M pkg/httplog/log.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-9
(2)

M pkg/kubectl/cmd/get.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-10
(25)

M pkg/kubectl/kubectl.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-11
(15)

M pkg/kubectl/resource/result.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-12
(2)

M pkg/kubectl/resource_printer.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-13
(68)

M pkg/master/master.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-14
(16)

M pkg/registry/event/rest.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-15
(4)

M pkg/registry/generic/etcd/etcd.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-16
(53)

M pkg/registry/generic/etcd/etcd_test.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-17
(263)

M pkg/registry/generic/registry.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-18
(4)

M pkg/registry/limitrange/rest.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-19
(4)

M pkg/registry/namespace/rest.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-20
(4)

M pkg/registry/pod/etcd/etcd.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-21
(8)

M pkg/registry/pod/etcd/etcd_test.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-22
(26)

M pkg/registry/pod/rest.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-23
(1)

A pkg/registry/podtemplate/doc.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-24
(18)

A pkg/registry/podtemplate/etcd/etcd.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-25
(62)

A pkg/registry/podtemplate/etcd/etcd_test.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-26
(100)

A pkg/registry/podtemplate/rest.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-27
(75)

M pkg/registry/resourcequota/rest.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-28
(4)

M pkg/registry/secret/rest.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-29
(4)

M pkg/tools/etcd_tools.go
https://github.com/GoogleCloudPlatform/kubernetes/pull/5012/files#diff-30
(3)

Patch Links:

https://github.com/GoogleCloudPlatform/kubernetes/pull/5012.patch

https://github.com/GoogleCloudPlatform/kubernetes/pull/5012.diff

—
Reply to this email directly or view it on GitHub
#5012.

bgrant0607 · 2015-03-05T19:13:48Z

Thanks!!

The main change is now the next-to-last commit. :-)

I'm fine with the API. I can see the benefit of an explicit template.

One thing to consider for separate templates: We may want to allow users to specify the resourceVersion of the template in the ObjectReference (the necessary field already exists) and force the replication controller to observe the specified version before it creates any new pods, for WAW consistency, if the user cares.

When this is ready for full review, let me know, though I may need to punt it to someone else.

bgrant0607 · 2015-03-14T23:52:40Z

I'm fine with this being v1beta3 only. I want to finalize v1beta3 and flip to it as the default asap.

Looking at the json, I see why you changed "spec" to "template". My main concern is whether we might add status in the future, such as to publish the last time the template was used to create a pod.

smarterclayton · 2015-03-15T01:16:41Z

I could certainly imagine a status in the future. Is an object that behaves like a template having a root "template" field better (obviousness) vs encouraging others to invent things besides spec. My thought was that spec is a real object which is converged, while a template isn't. Might be good to get a few other opinions.

On Mar 14, 2015, at 7:52 PM, Brian Grant notifications@github.com wrote:

I'm fine with this being v1beta3 only. I want to finalize v1beta3 and flip to it as the default asap.

Looking at the json, I see why you changed "spec" to "template". My main concern is whether we might add status in the future, such as to publish the last time the template was used to create a pod.

—
Reply to this email directly or view it on GitHub.

bgrant0607 · 2015-03-15T03:55:25Z

@smarterclayton You're logic is reasonable. I don't really want to bikeshed on this particular topic. Let's go with template.

piosz · 2015-04-08T16:54:01Z

Is this PR active? If not please close it according to https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/devel/pull-requests.md

smarterclayton · 2015-04-08T17:39:31Z

Yes

On Apr 8, 2015, at 12:54 PM, Piotr Szczesniak notifications@github.com wrote:

Is this PR active? If not please close it according to https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/devel/pull-requests.md

—
Reply to this email directly or view it on GitHub.

smarterclayton · 2015-04-20T18:29:21Z

Rebased and ready to use.

smarterclayton · 2015-04-20T18:29:27Z

Ready for review

bgrant0607 · 2015-04-20T22:46:48Z

Cool, thanks. Will take a look.

You're getting a gendocs failure due to the addition of a new noun.

wojtek-t · 2015-04-21T14:28:06Z

/subscribe

smarterclayton · 2015-04-21T21:22:18Z

Yes

----- Original Message -----

Looks pretty good. Found only one minor problem.

The next steps are to expose a subresource for creating pods from the
template, and then to use that in the replication controller?

Reply to this email directly or view it on GitHub:
#5012 (comment)

bgrant0607 · 2015-04-21T21:22:48Z

pkg/registry/podtemplate/etcd/etcd.go

+}
+
+// NewREST returns a RESTStorage object that will work against pod templates.
+func NewREST(h tools.EtcdHelper) *REST {


Love how simple this is now.

Yeah, reduced about 5k lines from openshift code base.

smarterclayton · 2015-04-21T21:23:48Z

Comments addressed.

bgrant0607 · 2015-04-21T21:24:16Z

Please regenerate the kubectl docs.

bgrant0607 · 2015-04-21T23:41:08Z

LGTM. Waiting for Travis.

bgrant0607 · 2015-04-22T03:27:49Z

# github.com/GoogleCloudPlatform/kubernetes/pkg/registry/controller/etcd
_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/registry/controller/etcd/etcd_test.go:78: unknown api.PodTemplate field 'Spec' in struct literal
FAIL    github.com/GoogleCloudPlatform/kubernetes/pkg/registry/controller/etcd [build failed]

smarterclayton · 2015-04-22T03:31:01Z

Weird.

bgrant0607 · 2015-04-22T14:17:12Z

Rerunning Travis. I have no idea what happened. Looks like Template to me.

bgrant0607 · 2015-04-22T14:37:24Z

Hmm. Still fails.

bgrant0607 · 2015-04-22T14:42:41Z

https://github.com/GoogleCloudPlatform/kubernetes/blob/1a2e4f8e1d35b38fde55414a3c61347f5894a24f/pkg/registry/controller/etcd/etcd_test.go#L63

smarterclayton · 2015-04-22T15:01:53Z

Fixed, merge changes coming in.

----- Original Message -----

https://github.com/GoogleCloudPlatform/kubernetes/blob/1a2e4f8e1d35b38fde55414a3c61347f5894a24f/pkg/registry/controller/etcd/etcd_test.go#L63

Reply to this email directly or view it on GitHub:
#5012 (comment)

bgrant0607 · 2015-04-22T16:20:53Z

Thanks. Tests passed, but needs to be rebased, apparently.

smarterclayton · 2015-04-22T18:29:06Z

Rebased and travis is green

Pod templates as their own type

googlebot added the cla: no label Mar 4, 2015

smarterclayton mentioned this pull request Mar 4, 2015

Small cleanups to a number of client behaviors #5013

Merged

smarterclayton force-pushed the podtemplates branch from 479199e to e262f92 Compare March 4, 2015 15:48

erictune assigned bgrant0607 Mar 4, 2015

smarterclayton force-pushed the podtemplates branch from e262f92 to 9dfbc56 Compare March 4, 2015 21:54

smarterclayton mentioned this pull request Mar 4, 2015

Implement v1beta3 api #1519

Closed

20 tasks

smarterclayton force-pushed the podtemplates branch from 9dfbc56 to 1da56ae Compare March 16, 2015 04:05

This was referenced Mar 17, 2015

Convert ReplicationController to a plugin (was ReplicationController redesign) #3058

Closed

Links to related object in json responses #3676

Closed

smarterclayton added kind/design Categorizes issue or PR as related to design. area/api Indicates an issue on api area. area/apiserver labels Mar 23, 2015

bgrant0607 mentioned this pull request Mar 25, 2015

Properly set object status #2726

Closed

bgrant0607 mentioned this pull request Apr 9, 2015

Default replica controller selector and labels using pod template. #6616

Merged

bgrant0607 mentioned this pull request Apr 17, 2015

Make PodTemplate an API objects #6976

Closed

smarterclayton force-pushed the podtemplates branch from 1da56ae to dff885b Compare April 20, 2015 18:27

smarterclayton changed the title ~~WIP - Pod templates as their own type~~ Pod templates as their own type Apr 20, 2015

bgrant0607 mentioned this pull request Apr 21, 2015

Replica Controller Name Annotation in Pods #5842

Merged

bgrant0607 reviewed Apr 21, 2015
View reviewed changes

smarterclayton force-pushed the podtemplates branch from dff885b to 5114242 Compare April 21, 2015 21:23

bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2015

bgrant0607 removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2015

smarterclayton force-pushed the podtemplates branch from 4c7f66c to e0b60b9 Compare April 22, 2015 15:00

bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. cla: yes and removed cla: no labels Apr 22, 2015

smarterclayton added 4 commits April 22, 2015 12:54

Pod Templates

10c2ace

Rename PodTemplate.Spec to PodTemplate.Template

e6e034a

Add swagger pod template output

7f1f0cd

Add completions

09d86b5

smarterclayton force-pushed the podtemplates branch from e0b60b9 to 09d86b5 Compare April 22, 2015 17:01

googlebot added cla: no and removed cla: yes labels Apr 22, 2015

bgrant0607 added a commit that referenced this pull request Apr 22, 2015

Merge pull request #5012 from smarterclayton/podtemplates

97302af

Pod templates as their own type

bgrant0607 merged commit 97302af into kubernetes:master Apr 22, 2015

errordeveloper mentioned this pull request Mar 9, 2017

should PodTemplatesGetter be part of public API #42789

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pod templates as their own type #5012

Pod templates as their own type #5012

smarterclayton commented Mar 4, 2015

googlebot commented Mar 4, 2015

pmorie commented Mar 4, 2015

type that only exists in v1beta3.

bgrant0607 commented Mar 5, 2015

bgrant0607 commented Mar 14, 2015

smarterclayton commented Mar 15, 2015

bgrant0607 commented Mar 15, 2015

piosz commented Apr 8, 2015

smarterclayton commented Apr 8, 2015

smarterclayton commented Apr 20, 2015

smarterclayton commented Apr 20, 2015

bgrant0607 commented Apr 20, 2015

wojtek-t commented Apr 21, 2015

smarterclayton commented Apr 21, 2015

bgrant0607 Apr 21, 2015

smarterclayton Apr 21, 2015

smarterclayton commented Apr 21, 2015

bgrant0607 commented Apr 21, 2015

bgrant0607 commented Apr 21, 2015

bgrant0607 commented Apr 22, 2015

smarterclayton commented Apr 22, 2015

bgrant0607 commented Apr 22, 2015

bgrant0607 commented Apr 22, 2015

bgrant0607 commented Apr 22, 2015

smarterclayton commented Apr 22, 2015

bgrant0607 commented Apr 22, 2015

smarterclayton commented Apr 22, 2015

Pod templates as their own type #5012

Pod templates as their own type #5012

Conversation

smarterclayton commented Mar 4, 2015

googlebot commented Mar 4, 2015

pmorie commented Mar 4, 2015

type that only exists in v1beta3.

bgrant0607 commented Mar 5, 2015

bgrant0607 commented Mar 14, 2015

smarterclayton commented Mar 15, 2015

bgrant0607 commented Mar 15, 2015

piosz commented Apr 8, 2015

smarterclayton commented Apr 8, 2015

smarterclayton commented Apr 20, 2015

smarterclayton commented Apr 20, 2015

bgrant0607 commented Apr 20, 2015

wojtek-t commented Apr 21, 2015

smarterclayton commented Apr 21, 2015

bgrant0607 Apr 21, 2015

Choose a reason for hiding this comment

smarterclayton Apr 21, 2015

Choose a reason for hiding this comment

smarterclayton commented Apr 21, 2015

bgrant0607 commented Apr 21, 2015

bgrant0607 commented Apr 21, 2015

bgrant0607 commented Apr 22, 2015

smarterclayton commented Apr 22, 2015

bgrant0607 commented Apr 22, 2015

bgrant0607 commented Apr 22, 2015

bgrant0607 commented Apr 22, 2015

smarterclayton commented Apr 22, 2015

bgrant0607 commented Apr 22, 2015

smarterclayton commented Apr 22, 2015