-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed VolumeSource in v1beta3 and internal. #5001
Conversation
@@ -88,12 +88,12 @@ func TestMerge(t *testing.T) { | |||
Spec: api.PodSpec{ | |||
Volumes: []api.Volume{ | |||
{ | |||
Name: "v1", | |||
Source: api.VolumeSource{EmptyDir: &api.EmptyDirVolumeSource{}}, | |||
Name: "v1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing? same below, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nm, i see you lined them up.
LTGM. I like this change. It's a little less verbose overall. I'll make the same changes to Persistent Volumes after this is merged. Thanks for the heads up. |
LGTM. Thanks. |
What about all the examples - I dont see any .json or .yaml files. |
I see at least 3 files using v1b3 and volumes: ./examples/mysql-wordpress-pd/v1beta3/mysql.yaml |
examples updated. (fwiw, I guess we need to expand coverage of our unit test to include those files, since that unit test passes) |
The problem with examples_test.go is that this is valid:
Unless validation catches a bad value, the tests will pass. |
LGTM |
Embed VolumeSource in v1beta3 and internal.
Closes #3858
@thockin @bgrant0607 @smarterclayton @markturansky