Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed VolumeSource in v1beta3 and internal. #5001

Merged
merged 1 commit into from
Mar 4, 2015

Conversation

brendandburns
Copy link
Contributor

@@ -88,12 +88,12 @@ func TestMerge(t *testing.T) {
Spec: api.PodSpec{
Volumes: []api.Volume{
{
Name: "v1",
Source: api.VolumeSource{EmptyDir: &api.EmptyDirVolumeSource{}},
Name: "v1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing? same below, too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nm, i see you lined them up.

@markturansky
Copy link
Contributor

LTGM. I like this change. It's a little less verbose overall. I'll make the same changes to Persistent Volumes after this is merged. Thanks for the heads up.

@bgrant0607
Copy link
Member

LGTM. Thanks.

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2015
@thockin
Copy link
Member

thockin commented Mar 4, 2015

What about all the examples - I dont see any .json or .yaml files.

@thockin thockin removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2015
@thockin
Copy link
Member

thockin commented Mar 4, 2015

I see at least 3 files using v1b3 and volumes:

./examples/mysql-wordpress-pd/v1beta3/mysql.yaml
./examples/mysql-wordpress-pd/v1beta3/wordpress.yaml
./examples/cassandra/v1beta3/cassandra-controller.yaml

@brendandburns
Copy link
Contributor Author

examples updated. (fwiw, I guess we need to expand coverage of our unit test to include those files, since that unit test passes)

@markturansky
Copy link
Contributor

The problem with examples_test.go is that this is valid:

kind: Pod
apiVersion: v1beta3
metadata:
  name: mypod
none:
  of:
    these:
      fields:
        exist: "but the test still passes"

Unless validation catches a bad value, the tests will pass.

@thockin
Copy link
Member

thockin commented Mar 4, 2015

LGTM

thockin added a commit that referenced this pull request Mar 4, 2015
Embed VolumeSource in v1beta3 and internal.
@thockin thockin merged commit fdea725 into kubernetes:master Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

for v1beta3: embed VolumeSource
6 participants