Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scheduledjobs #49930

Merged
merged 2 commits into from
Aug 9, 2017
Merged

Remove scheduledjobs #49930

merged 2 commits into from
Aug 9, 2017

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Aug 1, 2017

This is a prerequisite for promoting CronJobs to beta.

Release note:

Remove deprecated ScheduledJobs endpoints, use CronJobs instead.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2017
@soltysh soltysh added area/workload-api/cronjob sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Aug 1, 2017
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 1, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Aug 1, 2017

/unsassign @enisoc @tallclair
/assign @smarterclayton

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2017
@soltysh soltysh force-pushed the remove_scheduledjobs branch from b653c70 to 55afa5e Compare August 8, 2017 11:55
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2017
@deads2k
Copy link
Contributor

deads2k commented Aug 8, 2017

Alpha resources can be dropped at any time and as I recall, cronjob (the transition) existed last release.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2017
@soltysh soltysh mentioned this pull request Aug 8, 2017
Closed
3 tasks
@soltysh soltysh force-pushed the remove_scheduledjobs branch from 55afa5e to 0cb8bae Compare August 8, 2017 14:25
@k8s-github-robot k8s-github-robot added kind/new-api and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 8, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Aug 8, 2017

/test pull-kubernetes-federation-e2e-gce

@soltysh
Copy link
Contributor Author

soltysh commented Aug 8, 2017

/test pull-kubernetes-e2e-gce-etcd3

@soltysh
Copy link
Contributor Author

soltysh commented Aug 8, 2017

/test pull-kubernetes-federation-e2e-gce

@smarterclayton
Copy link
Contributor

/approve

Fits the requirements for one release alpha removal and a beta or higher replacement exists.

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k, smarterclayton, soltysh

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor Author

soltysh commented Aug 9, 2017

/test pull-kubernetes-federation-e2e-gce

@soltysh
Copy link
Contributor Author

soltysh commented Aug 9, 2017

The PR was lgtmed and approved, for some reason the bot didn't picked up the approval. I'll apply the labels manually.

@soltysh soltysh added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 9, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50016, 49583, 49930, 46254, 50337)

@k8s-github-robot k8s-github-robot merged commit 212928a into kubernetes:master Aug 9, 2017
@soltysh soltysh deleted the remove_scheduledjobs branch August 10, 2017 08:11
@pwittrock
Copy link
Member

pwittrock commented Aug 18, 2017 •
edited
Loading

This looks to have broken the kubectl skew tests. Please create a patch to the 1.7 branch to disable the test when running against a 1.8+ cluster.

@pwittrock
Copy link
Member

@soltysh @smarterclayton @deads2k

@pwittrock pwittrock mentioned this pull request Aug 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/workload-api/cronjob cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@soltysh @deads2k @smarterclayton @k8s-github-robot @pwittrock @enisoc @k8s-ci-robot @tallclair