Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed zoneNotReadyOrUnreachableTainer to zoneNoExecuteTainer. #49870

Merged
merged 2 commits into from
Aug 2, 2017
Merged

Renamed zoneNotReadyOrUnreachableTainer to zoneNoExecuteTainer. #49870

merged 2 commits into from
Aug 2, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Jul 31, 2017

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): partially fixes #42001

Release note:

None

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 31, 2017
@k82cn
Copy link
Member Author

k82cn commented Jul 31, 2017

/assign @gmarek
/unassign @smarterclayton @ingvagabund

@k82cn k82cn mentioned this pull request Jul 31, 2017
Merged
@gmarek
Copy link
Contributor

gmarek commented Jul 31, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, k82cn

Associated issue: 42001

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2017
@k82cn
Copy link
Member Author

k82cn commented Jul 31, 2017

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49870, 49416, 49872, 49892, 49908)

@k8s-github-robot k8s-github-robot merged commit 455d85a into kubernetes:master Aug 2, 2017
@k82cn k82cn deleted the nc_rename_zone_tainer branch August 2, 2017 02:59
@k82cn k82cn mentioned this pull request Aug 2, 2017
Closed
@davidopp davidopp mentioned this pull request Sep 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NodeController should add NoSchedule taints and we should get rid of getNodeConditionPredicate()
7 participants
@k82cn @gmarek @k8s-github-robot @fejta-bot @smarterclayton @ingvagabund @k8s-ci-robot