Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add label examples for kubectl run #49862

Merged
merged 1 commit into from
Aug 5, 2017
Merged

add label examples for kubectl run #49862

merged 1 commit into from
Aug 5, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Jul 31, 2017 •
edited
Loading

What this PR does / why we need it:

Add --labels examples for kubectl run

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
xref #49854

Special notes for your reviewer:
/cc @ahmetb

Release note:

add examples for kubectl run --labels

@k8s-ci-robot k8s-ci-robot requested a review from ahmetb July 31, 2017 07:03
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 31, 2017
@dixudx dixudx force-pushed the kubectl_run_labels branch from 05bc269 to 3d35a07 Compare July 31, 2017 07:05
@deads2k deads2k assigned fabianofranz and unassigned deads2k Jul 31, 2017
@ahmetb
Copy link
Member

ahmetb commented Jul 31, 2017

/ok-to-test

@fabianofranz
Copy link
Contributor

/retest

@dixudx
Copy link
Member Author

dixudx commented Aug 1, 2017

/test pull-kubernetes-e2e-kops-aws

2 similar comments
@dixudx
Copy link
Member Author

dixudx commented Aug 1, 2017

/test pull-kubernetes-e2e-kops-aws

@dixudx
Copy link
Member Author

dixudx commented Aug 1, 2017

/test pull-kubernetes-e2e-kops-aws

@dixudx
Copy link
Member Author

dixudx commented Aug 1, 2017

pull-kubernetes-node-e2e did not report CI success here.

/test pull-kubernetes-node-e2e

@dixudx
Copy link
Member Author

dixudx commented Aug 1, 2017

@ahmetb @fabianofranz @derekwaynecarr PTAL. Need your approval. Thanks.

@ahmetb
Copy link
Member

ahmetb commented Aug 1, 2017 •
edited
Loading

/lgtm

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2017
@fabianofranz
Copy link
Contributor

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-etcd3

@ahmetb
Copy link
Member

ahmetb commented Aug 1, 2017

If approved, we can skip the flaky checks. If there are no issues created about the flakes you're seeing please consider creating an issue.

@fabianofranz
Copy link
Contributor

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2017
@dixudx
Copy link
Member Author

dixudx commented Aug 2, 2017

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2017
@fabianofranz
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahmetb, dixudx, fabianofranz
We suggest the following additional approver: thockin

Assign the PR to them by writing /assign @thockin in a comment when ready.

Associated issue: 49854

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dixudx
Copy link
Member Author

dixudx commented Aug 3, 2017

@brendandburns @thockin Need your approval. Thanks.

@dixudx
Copy link
Member Author

dixudx commented Aug 4, 2017

/assign @smarterclayton @thockin
Need your approval. Thanks.

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700)

@k8s-github-robot k8s-github-robot merged commit eeb72d7 into kubernetes:master Aug 5, 2017
@dixudx dixudx deleted the kubectl_run_labels branch August 5, 2017 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb Awaiting requested review from ahmetb

Assignees

@fabianofranz fabianofranz

@ahmetb ahmetb

@smarterclayton smarterclayton

@thockin thockin

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dixudx @k8s-ci-robot @ahmetb @fabianofranz @k8s-github-robot @smarterclayton @thockin @derekwaynecarr @deads2k