Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dashboard image version #49855

Merged
merged 1 commit into from
Aug 6, 2017
Merged

update dashboard image version #49855

merged 1 commit into from
Aug 6, 2017
+1 −1

Conversation

zouyee
Copy link
Member

@zouyee zouyee commented Jul 31, 2017 •
edited
Loading

fix #50195
What this PR does / why we need it:
Updates dashboard addon to latest version. Changelog can be found here.

Release note:

Update dashboard version to v1.6.3

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @zouyee. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 31, 2017
@zouyee zouyee mentioned this pull request Jul 31, 2017
Closed
@maciaszczykm
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2017
@maciaszczykm
Copy link
Member

/retest

1 similar comment
@zouyee
Copy link
Member Author

zouyee commented Jul 31, 2017

/retest

@zouyee
Copy link
Member Author

zouyee commented Aug 1, 2017 •
edited
Loading

@jbeda @roberthbailey PTAL

@roberthbailey
Copy link
Contributor

I'm happy to approve if someone from the dashboard dev team gives an LGTM, as I'm not really qualified to know what is contained in this version bump.

@zouyee
Copy link
Member Author

zouyee commented Aug 2, 2017 •
edited
Loading

@maciaszczykm @floreks PTAL

@floreks
Copy link
Member

floreks commented Aug 2, 2017

@roberthbailey LGTM. v1.6.3 is a latest stable release.

@roberthbailey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

@zouyee: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@floreks
Copy link
Member

floreks commented Aug 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Aug 3, 2017
@floreks
Copy link
Member

floreks commented Aug 3, 2017 •
edited
Loading

@zouyee update your first comment similar to this: #43210
Release notes are required.

@zouyee
Copy link
Member Author

zouyee commented Aug 3, 2017

done!

@floreks
Copy link
Member

floreks commented Aug 3, 2017

/approve no-issue

@zouyee
Copy link
Member Author

zouyee commented Aug 4, 2017

gentle ping @roberthbailey

@roberthbailey
Copy link
Contributor

The PR is approved but the bot won't merge it until you link it to an issue. This is a new requirement from @kubernetes/sig-release-members

@maciaszczykm
Copy link
Member

@zouyee Can you create issue and link it here so bot will pick it up?

@zouyee zouyee mentioned this pull request Aug 5, 2017
Closed
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2017
@zouyee
Copy link
Member Author

zouyee commented Aug 5, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, roberthbailey, zouyee

Associated issue: 50195

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@zouyee
Copy link
Member Author

zouyee commented Aug 6, 2017

how to fix it (not auto merge because do-not-merge is present)? @maciaszczykm

@jbeda
Copy link
Contributor

jbeda commented Aug 6, 2017

/release-note

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Aug 6, 2017
@jbeda jbeda removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Aug 6, 2017
@jbeda
Copy link
Contributor

jbeda commented Aug 6, 2017

Manually removed do-not-merge label. Not sure how to get the merge robot to remove it automatically as it is the one that added it.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49855, 49915)

@k8s-github-robot k8s-github-robot merged commit e2baa8e into kubernetes:master Aug 6, 2017
@abitrolly
Copy link

Which version of Kubernetes contains this fix?

Is it possible to deliver it to 1.7.x branch also? (1.7.6 still comes with Dashboard 1.6.1)

@maciaszczykm
Copy link
Member

@abitrolly You can check it on GitHub: a57e3ea

v1.9.0-alpha.1 v1.9.0-alpha.0 v1.8.0-rc.1 v1.8.0-beta.1 v1.8.0-beta.0 v1.8.0-alpha.3

@abitrolly
Copy link

abitrolly commented Sep 29, 2017 •
edited
Loading

@maciaszczykm thanks. Pull request version doesn't show this. https://github.com/kubernetes/kubernetes/pull/49855/commits/a57e3eab1fde6438b6fac7b0e6c9b7d0d5a3db70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeda jbeda

@floreks floreks

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update dashboard image version
8 participants
@zouyee @k8s-ci-robot @maciaszczykm @roberthbailey @floreks @k8s-github-robot @jbeda @abitrolly