Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make volumesInUse sorted in node status updates #49849

Merged
merged 1 commit into from
Aug 27, 2017
Merged

make volumesInUse sorted in node status updates #49849

merged 1 commit into from
Aug 27, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Jul 30, 2017

What this PR does / why we need it:

volumesInUse is not sent in a stable sort order. This will make node status patch requests larger than needed, and makes debugging nodes harder than necessary.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49731

Special notes for your reviewer:

/cc @derekwaynecarr @jboyd01

Release note:

make volumesInUse sorted in node status updates

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2017
@k8s-ci-robot
Copy link
Contributor

@dixudx: GitHub didn't allow me to request PR reviews from the following users: jboyd01.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

volumesInUse is not sent in a stable sort order. This will make node status patch requests larger than needed, and makes debugging nodes harder than necessary.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49731

Special notes for your reviewer:

/cc @derekwaynecarr @jboyd01

Release note:

make volumesInUse sorted in node status updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 30, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 30, 2017
@dixudx
Copy link
Member Author

dixudx commented Aug 1, 2017

/assign @saad-ali

@dixudx
Copy link
Member Author

dixudx commented Aug 5, 2017

/assign @derekwaynecarr

@dixudx dixudx mentioned this pull request Aug 7, 2017
Closed
@jboyd01
Copy link

jboyd01 commented Aug 11, 2017

LGTM @dixudx. When I looked at this issue a couple weeks ago I had the same change and was attempting to come up with a unit test to cover the code change. Not necessary for such a simple change but I thought it would be good.

@dixudx
Copy link
Member Author

dixudx commented Aug 12, 2017

@saad-ali PTAL. I think this PR is ready for review. Thanks.

@derekwaynecarr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2017
@dixudx
Copy link
Member Author

dixudx commented Aug 12, 2017

@saad-ali @derekchiang Need your /approval. Thanks.

@derekwaynecarr
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, dixudx

Associated issue: 49731

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@dixudx
Copy link
Member Author

dixudx commented Aug 27, 2017

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49849, 50334, 51414)

@k8s-github-robot k8s-github-robot merged commit cbe5f38 into kubernetes:master Aug 27, 2017
@dixudx dixudx deleted the stable_sort_volumesInUse branch August 27, 2017 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@sjpotter sjpotter

@Random-Liu Random-Liu

@derekwaynecarr derekwaynecarr

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubelet send volumesInUse sorted in status updates
9 participants
@dixudx @k8s-ci-robot @jboyd01 @derekwaynecarr @k8s-github-robot @fejta-bot @sjpotter @Random-Liu @saad-ali