Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash kube2sky after repeated etcd mutation failures. #4980

Merged
merged 1 commit into from
Mar 5, 2015
Merged

Crash kube2sky after repeated etcd mutation failures. #4980

merged 1 commit into from
Mar 5, 2015

Conversation

rsokolowski
Copy link
Contributor

Addresses #4814 to large degree.
I wasn't able to do etcd liveness check. Instead kube2sky will keep retrying to configurable period of time and then will just crash.
I've verified that it makes kube2sky more robust in case if etcd is not available and kube2sky would just stopped working. With this PR it will just crash and then come back successfully.

@rsokolowski
Copy link
Contributor Author

While on the PR I have question regarding making the PR live after it being merged: should I build kubernetes/kube2sky:1.1 and change skydns-rc.yaml.in or is it done in separate process ?

@zmerlynn
Copy link
Member

zmerlynn commented Mar 3, 2015

cc @fabioy

thockin
thockin reviewed Mar 3, 2015
View reviewed changes
cluster/addons/dns/kube2sky/README.md
@@ -20,3 +20,6 @@ example, if this is set to `kubernetes.io`, then a service named "nifty" in the
"nifty.default.kubernetes.io".

`-verbose`: Log additional information.

'-etcd_mutation_timeout': For how long the application with keep retrying etcd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/with/will

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@thockin thockin self-assigned this Mar 3, 2015
@thockin
Copy link
Member

thockin commented Mar 3, 2015

As for rebuilding kube2sky, yes. Once this is committed we should build and tag a new one and push it, then update the yaml.

@rsokolowski rsokolowski force-pushed the skydns-resilient-to-restart branch 2 times, most recently from 6c4add6 to 297542d Compare March 4, 2015 07:29
@rsokolowski
Copy link
Contributor Author

Thanks for the comments @thockin. Applied them, rebased/squashed and tested in a cluster that it still works.

@rsokolowski rsokolowski force-pushed the skydns-resilient-to-restart branch from 297542d to e7438f5 Compare March 4, 2015 10:29
@rsokolowski rsokolowski force-pushed the skydns-resilient-to-restart branch from e7438f5 to 5026142 Compare March 5, 2015 07:31
@thockin
Copy link
Member

thockin commented Mar 5, 2015

LGTM - do you want to rebuild and push a 1.1 container, or do you want me to?

thockin added a commit that referenced this pull request Mar 5, 2015
@thockin
Merge pull request #4980 from rsokolowski/skydns-resilient-to-restart
c021719 
Crash kube2sky after repeated etcd mutation failures.
@thockin thockin merged commit c021719 into kubernetes:master Mar 5, 2015
@rsokolowski
Copy link
Contributor Author

I will do that and also send a PR for skydns config.
5 mar 2015 6:22 PM "Tim Hockin" notifications@github.com napisał(a):

LGTM - do you want to rebuild and push a 1.1 container, or do you want me
to?

—
Reply to this email directly or view it on GitHub
#4980 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsokolowski @zmerlynn @thockin @googlebot