Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix apps DeploymentSpec conversion issue #49719

Merged
merged 1 commit into from
Aug 12, 2017
Merged

fix apps DeploymentSpec conversion issue #49719

merged 1 commit into from
Aug 12, 2017
+4 −4

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Jul 27, 2017

What this PR does / why we need it:

When working on #49645, I found current conversion for v1.PodTemplateSpec to api.PodTemplateSpec did not work properly. It should function as L244-L246.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
/cc @janetkuo

Release note:

fix apps DeploymentSpec conversion issue

@k8s-ci-robot k8s-ci-robot requested a review from janetkuo July 27, 2017 13:40
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 27, 2017
@dims
Copy link
Member

dims commented Jul 27, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 28, 2017

/cc @caesarxuchao

@dims
Copy link
Member

dims commented Jul 28, 2017

/assign @erictune

@dixudx
Copy link
Member Author

dixudx commented Jul 28, 2017

@janetkuo @caesarxuchao @erictune PTAL. Thanks.

@dixudx dixudx mentioned this pull request Jul 28, 2017
Merged
@dixudx
Copy link
Member Author

dixudx commented Aug 4, 2017

/assign @janetkuo @caesarxuchao

@dims
Copy link
Member

dims commented Aug 4, 2017

/unassign @dims

@janetkuo
Copy link
Member

janetkuo commented Aug 6, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2017
@dixudx
Copy link
Member Author

dixudx commented Aug 6, 2017

/assign @lavalamp @thockin

Needs your approval. Thanks.

@dixudx
Copy link
Member Author

dixudx commented Aug 12, 2017

/test pull-kubernetes-e2e-gce-etcd3

@thockin
Copy link
Member

thockin commented Aug 12, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, janetkuo, thockin

Associated issue: 49645

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit c1da492 into kubernetes:master Aug 12, 2017
@dixudx dixudx deleted the fix_apps_deploymentspec_conversion branch August 12, 2017 05:21
k8s-github-robot pushed a commit that referenced this pull request Sep 1, 2017
Merge pull request #49645 from dixudx/v1beta2_conversion_test
5f405b7 
Automatic merge from submit-queue (batch tested with PRs 50381, 51307, 49645, 50995, 51523)

add apps/v1beta2 conversion tests

**What this PR does / why we need it**:

add apps/v1beta2 conversion test

Depend on ~~#49751~~(Merged), ~~#49719~~(Merged)

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:
/cc @janetkuo 

**Release note**:

```release-note
add apps/v1beta2 conversion test
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@lavalamp lavalamp

@caesarxuchao caesarxuchao

@janetkuo janetkuo

@thockin thockin

@erictune erictune

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dixudx @k8s-ci-robot @dims @janetkuo @thockin @k8s-github-robot @lavalamp @caesarxuchao @erictune