Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rbac.authorization.k8s.io/v1 #49642

Merged
merged 2 commits into from
Aug 10, 2017
Merged

Add rbac.authorization.k8s.io/v1 #49642

merged 2 commits into from
Aug 10, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 26, 2017 •
edited
Loading

xref kubernetes/enhancements#2

Promotes the rbac.authorization.k8s.io/v1beta1 API to v1 with no changes

The `rbac.authorization.k8s.io/v1beta1` API has been promoted to `rbac.authorization.k8s.io/v1` with no changes.
The `rbac.authorization.k8s.io/v1alpha1` version is deprecated and will be removed in a future release.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2017
@k8s-github-robot k8s-github-robot added kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 26, 2017
@liggitt
Copy link
Member Author

liggitt commented Jul 26, 2017

/assign @deads2k
/assign @ericchiang
@kubernetes/sig-auth-api-reviews
@kubernetes/api-reviewers

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jul 26, 2017
@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 26, 2017
@deads2k
Copy link
Contributor

deads2k commented Jul 26, 2017

/approve

@MHBauer
Copy link
Contributor

MHBauer commented Jul 26, 2017

super duper.

@liggitt liggitt force-pushed the rbac-v1 branch 4 times, most recently from 4e8ab49 to 64ef9dd Compare July 27, 2017 04:09
wanghaoran1988
wanghaoran1988 reviewed Jul 27, 2017
View reviewed changes
pkg/apis/rbac/v1/helpers.go
"fmt"

rbacv1 "k8s.io/api/rbac/v1"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, should we remove the empty line?

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2017
@liggitt liggitt force-pushed the rbac-v1 branch 2 times, most recently from 56b945f to 68af281 Compare August 3, 2017 13:42
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2017
@ericchiang
Copy link
Contributor

/lgtm

🎉

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@liggitt
Copy link
Member Author

liggitt commented Aug 9, 2017 

I0809 13:50:02.026] +++ [0809 13:50:02] Building go targets for linux/amd64:
I0809 13:50:02.026]     cmd/hyperkube
I0809 13:50:23.379] Terminate 16480 on timeout
E0809 13:50:23.481] Build timed out
E0809 13:50:23.481] Command failed
I0809 13:50:23.481] process 16480 exited with code -15 after 59.4m

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@liggitt
Copy link
Member Author

liggitt commented Aug 9, 2017

build timeout after 1 hour
/retest

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2017
@liggitt
Copy link
Member Author

liggitt commented Aug 9, 2017

rebased, no idea why the verify job is hitting timeouts... nothing obvious is hanging

@liggitt liggitt mentioned this pull request Aug 10, 2017
Closed
@liggitt
Copy link
Member Author

liggitt commented Aug 10, 2017 •
edited
Loading

verify timeout issues resolved
/retest

@liggitt
Copy link
Member Author

liggitt commented Aug 10, 2017

Verify flakes resolved, retagging

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 10, 2017 •
edited
Loading

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce 06c4942 link /test pull-kubernetes-federation-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49642, 50335, 50390, 49283, 46582)

@k8s-github-robot k8s-github-robot merged commit 85e2e5d into kubernetes:master Aug 10, 2017
@liggitt liggitt deleted the rbac-v1 branch August 10, 2017 15:02
@nikhiljindal nikhiljindal mentioned this pull request Aug 11, 2017
Closed
@xilabao xilabao mentioned this pull request Aug 21, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Aug 24, 2017
Merge pull request #51011 from xilabao/rbac-v1-in-yaml
3b2e403 
Automatic merge from submit-queue (batch tested with PRs 50489, 51070, 51011, 51022, 51141)

update to rbac v1 in yaml file

**What this PR does / why we need it**:
ref to #49642
ref kubernetes/enhancements#2

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:
cc @liggitt 

**Release note**:

```release-note
NONE
```
@deads2k deads2k mentioned this pull request Aug 24, 2017
Merged
@wking wking mentioned this pull request Jul 29, 2020
Merged
wking added a commit to wking/cluster-version-operator that referenced this pull request Jul 30, 2020
@wking
lib/resourceread/rbac: Ensure v1beta1 conversion
c41eac0 
Protecting us from [1,2]:

  converting (v1beta1.Role) to (v1.Role): unknown conversion

in unit tests.  The manual conversion and wash through JSON seems like
a terrible hack, but I haven't been able to figure out a more elegant
approach yet.  From [3]:

  Promotes the rbac.authorization.k8s.io/v1beta1 API to v1 with no changes

so all we really need is the apiVersion bump.

[1]: kubernetes/kubernetes#90018
[2]: openshift#420 (comment)
[3]: kubernetes/kubernetes#49642
wking added a commit to wking/cluster-version-operator that referenced this pull request Jul 30, 2020
@wking
lib/resourceread/rbac: Ensure v1beta1 conversion
55be2f2 
Protecting us from [1,2]:

  converting (v1beta1.Role) to (v1.Role): unknown conversion

in unit tests.  The manual conversion and wash through JSON seems like
a terrible hack, but I haven't been able to figure out a more elegant
approach yet.  From [3]:

  Promotes the rbac.authorization.k8s.io/v1beta1 API to v1 with no changes

so all we really need is the apiVersion bump.

[1]: kubernetes/kubernetes#90018
[2]: openshift#420 (comment)
[3]: kubernetes/kubernetes#49642
wking added a commit to wking/cluster-version-operator that referenced this pull request Jul 30, 2020
@wking
lib/resourceread/rbac: Ensure v1beta1 conversion
6f247d4 
Protecting us from [1,2]:

  converting (v1beta1.Role) to (v1.Role): unknown conversion

in unit tests.  The manual conversion and wash through JSON seems like
a terrible hack, but I haven't been able to figure out a more elegant
approach yet.  From [3]:

  Promotes the rbac.authorization.k8s.io/v1beta1 API to v1 with no changes

so all we really need is the apiVersion bump.

Also add similar logic for apiregistration, since that's the other
group where we register multiple schema versions.

[1]: kubernetes/kubernetes#90018
[2]: openshift#420 (comment)
[3]: kubernetes/kubernetes#49642
wking added a commit to wking/cluster-version-operator that referenced this pull request Jul 31, 2020
@wking
lib: Add autogeneration for some resource* functionality
8a020a7 
Protecting us from [1,2]:

  converting (v1beta1.Role) to (v1.Role): unknown conversion

Because merging and application are also version-dependent, it's hard
to paper over this in resourceread with automatic type conversion.
Although from [3]:

  Promotes the rbac.authorization.k8s.io/v1beta1 API to v1 with no changes

so all we really need is the apiVersion bump.  Anyhow, with this
commit, I'm doubling down on the approach from 4ee7b07 (Add
apiextensions.k8s.io/v1 support for CRDs, 2019-10-22, openshift#259) and
collapsing the readers into two helpers that support all of our types
and return runtime.Object.

From 0a255ab (cvo: Use protobuf for sending events and other basic
API commands, 2019-01-18, openshift#90), protobuf is more efficient, so we
should use it where possible.

And because all of this is very tedious to maintain by hand, there's
now a Python generator to spit out all the boilerplate.

[1]: kubernetes/kubernetes#90018
[2]: openshift#420 (comment)
[3]: kubernetes/kubernetes#49642
wking added a commit to wking/cluster-version-operator that referenced this pull request Jul 31, 2020
@wking
lib: Add autogeneration for some resource* functionality
e8ffccb 
Protecting us from [1,2]:

  converting (v1beta1.Role) to (v1.Role): unknown conversion

Because merging and application are also version-dependent, it's hard
to paper over this in resourceread with automatic type conversion.
Although from [3]:

  Promotes the rbac.authorization.k8s.io/v1beta1 API to v1 with no changes

so all we really need is the apiVersion bump.  Anyhow, with this
commit, I'm doubling down on the approach from 4ee7b07 (Add
apiextensions.k8s.io/v1 support for CRDs, 2019-10-22, openshift#259) and
collapsing the readers into two helpers that support all of our types
and return runtime.Object.

From 0a255ab (cvo: Use protobuf for sending events and other basic
API commands, 2019-01-18, openshift#90), protobuf is more efficient, so we
should use it where possible.

And because all of this is very tedious to maintain by hand, there's
now a Python generator to spit out all the boilerplate.

[1]: kubernetes/kubernetes#90018
[2]: openshift#420 (comment)
[3]: kubernetes/kubernetes#49642
@czomo czomo mentioned this pull request Dec 13, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghaoran1988 wanghaoran1988 wanghaoran1988 left review comments

Assignees

@smarterclayton smarterclayton

@ericchiang ericchiang

@erictune erictune

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.