Remove default binding of system:node role to system:nodes group #49638
+8
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/M
|
cc @kubernetes/sig-auth-pr-reviews |
k8s-ci-robot
added
the
sig/auth
liggitt
force-pushed
the
remove-nodes-binding
branch
from
da9e0a0 to
139f268
Compare
ericchiang
added
the
release-note-action-required
liggitt
removed
the
release-note
liggitt
force-pushed
the
remove-nodes-binding
branch
from
139f268 to
d65610b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ericchiang, liggitt Associated issue: 279 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Communicated to cluster-lifecycle? |
|
/retest |
|
@smarterclayton thanks. Sent a notice to the cluster lifecycle mailing list https://groups.google.com/forum/#!topic/kubernetes-sig-cluster-lifecycle/1OIjHX-A3sI |
|
Automatic merge from submit-queue (batch tested with PRs 49619, 49598, 47267, 49597, 49638) |
k8s-github-robot
pushed a commit
that referenced
this pull request
Jul 31, 2017
Automatic merge from submit-queue Enable node authorizer in local-up-cluster Fixes #49822 Enables the Node authorization mode to ensure the kubelet credential we create has permission to do kubelet-related things. Matches the default authorizers in gce/gke and CI clusters. Related to the deprecation of the automatic binding of the `system:nodes` group to the `system:node` role on new deployments (#49638) ```release-note `hack/local-up-cluster.sh` now enables the Node authorizer by default. Authorization modes can be overridden with the `AUTHORIZATION_MODE` environment variable, and the `ENABLE_RBAC` environment variable is no longer used. ```
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of kubernetes/enhancements#279
deprecation of this automatic binding announced in 1.7 in #46076