Remove host ports from the update demo and update tests (take 2). #4963
+85
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cmd := exec.Command("kubectl", kubectlArgs...) | ||
| Logf("Running '%s %s'", cmd.Path, strings.Join(cmd.Args, " ")) |
There was a problem hiding this comment.
Move the log line into runKubectl, since this only creates the command.
There was a problem hiding this comment.
Then I'll need to duplicate it in BeforeEach as well (since that also runs kubectl). I put it here to try and avoid the code duplication.
There was a problem hiding this comment.
Fair enough. It's also just a Logf, so I don't have strong feelings.
|
LGTM, other than nit. |
|
Shippable is a flake. Merging. |
j3ffml
added a commit
that referenced
this pull request
Mar 2, 2015
Remove host ports from the update demo and update tests (take 2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #4537.
The previous attempt didn't work because what was being spawned in the BeforeEach function wasn't kubectl (the go binary) but instead kubectl.sh (the shell wrapper). Killing the shell wrapper in the AfterEach function left kubectl running as an orphan process (since we aren't using a process group or running from inside a shell that helps clean up orphans).
Tested on GCE and GKE (10 consecutive runs each). On the first set of runs on GKE, one of the runs failed with
501: All the given peers are not reachable (Tried to connect to each peer twice and failed)and on the second set all 10 passed.