Use proxy instead of load balancer for Elasticsearch and Kibana #4959
Conversation
|
A heads up to @jeffmendoza @mikedanese @justinsb |
|
@satnam6502: With this change, will users be able to specify a public IP on the 'kibana-logging' service and be able to access kibana UI directly? |
| @@ -1,6 +1,6 @@ | |||
| .PHONY: build push | |||
|
|
|||
| TAG = 1.0 | |||
| TAG = 1.1 | |||
There was a problem hiding this comment.
Scary-- if someone with the keys to the kubernetes dockerhub user (e.g. me) builds this makefile, we'll blow away the official image.
There was a problem hiding this comment.
Do you have a better suggestion for how to handle this?
There was a problem hiding this comment.
Unfortunately, not familiar enough with Makefiles to have a suggestion. I guess it'd be nice if there was some special step to promote something to have official version tags?
|
LGTM |
Use proxy instead of load balancer for Elasticsearch and Kibana
|
...should I have asked for an e2e run before merging this? I guess we'll find out. |
|
@vishh : no, setting a public IP in the service spec will not wok for Kibana (although fine for Elasticsearch). This is because the Kibana image has this URL for Elasticsearch set in the JS config: which is expressed in terms of the proxy. |
|
@lavalamp : I am now finally unblocked for writing the actual e2e test for cluster level logging. |
This change:
kubernetes/kibanaimage to specify the Elasticsearch service using its proxy address and removes the nginx proxy_pass config which is no logner needed.util.shto report the URL of the cluster level services.If the trailing lash is missing from
https://MASTER/api/v1beta1/proxy/services/kibana-logging/the Kibana page will not load properly. Something is broken -- either with us or Kibana.FYI: @vishh @piosz