Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capacity information to 'kubectl describe minion' #4952

Merged
merged 1 commit into from
Mar 2, 2015
Merged

Add capacity information to 'kubectl describe minion' #4952

merged 1 commit into from
Mar 2, 2015
+6 −0

Conversation

rjnagal
Copy link
Contributor

@rjnagal rjnagal commented Mar 2, 2015

Sample output:

# kubectl describe  mi e2e-test-jnagal-minion-4p47
Name:   e2e-test-jnagal-minion-4p47
Conditions:
  Type  Status  LastProbeTime   LastTransitionTime  Reason  Message
  Ready Full Mon, 02 Mar 2015 18:43:37 +0000 Fri, 27 Feb 2015 22:22:05 +0000 Node health check succeeded: kubelet /healthz endpoint returns ok 
Capacity:
 cpu:   1
 memory:    1825361100
Pods:   (3 in total)
...

@vmarmol
Copy link
Contributor

vmarmol commented Mar 2, 2015

Nice :) LGTM

@dchen1107 dchen1107 self-assigned this Mar 2, 2015
@dchen1107
Copy link
Member

I think we agreed to remove minions completely from kubectl, can you change this to "kubectl describe nodes id"

cc/ @ddysher since he is exposing events for kubectl describe nodes id too

@rjnagal
Copy link
Contributor Author

rjnagal commented Mar 2, 2015

@dchen1107 This is the same command for both node/minion. They resolve to the same resource.
'kubectl describe nodes id' will give the same result.

@dchen1107
Copy link
Member

LGTM

dchen1107 added a commit that referenced this pull request Mar 2, 2015
@dchen1107
Merge pull request #4952 from rjnagal/kubectl
93c0052 
Add capacity information to 'kubectl describe minion'
@dchen1107 dchen1107 merged commit 93c0052 into kubernetes:master Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjnagal @vmarmol @dchen1107 @googlebot