Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waiting for GCE Operations #4938

Merged
merged 1 commit into from
Mar 2, 2015
Merged

Conversation

tkulczynski
Copy link
Contributor

GCE Operation status "DONE" does not necessarily mean the operation succeeded - one has to also check if any errors are populated, see https://cloud.google.com/compute/docs/reference/latest/regionOperations (there are only DONE/PEDNING/RUNNING statuses so clearly no indication of whether it failed or suceeded, while the error field description says "[Output Only] If errors occurred during processing of this operation, this field will be populated.").
The mistake was made probably because GCE Go API returns an Operation object and an error, but the latter is only set when it was not possible to get the Operation object and does not imply anything about the content of the Operation.

@roberthbailey
Copy link
Contributor

/cc @cjcullen

@brendandburns
Copy link
Contributor

LGTM.

brendandburns added a commit that referenced this pull request Mar 2, 2015
Fix waiting for GCE Operations
@brendandburns brendandburns merged commit 843fa71 into kubernetes:master Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants