Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using named ports in examples and scripts. #4937

Merged
merged 1 commit into from
Mar 2, 2015
Merged

Stop using named ports in examples and scripts. #4937

merged 1 commit into from
Mar 2, 2015

Conversation

thockin
Copy link
Member

@thockin thockin commented Mar 2, 2015

even if we can't turn it off completely yet (TBD) we can stop endorsing it.

@sub-mod
Copy link
Contributor

sub-mod commented Mar 2, 2015

@thockin Why is this a bad practice ?

@brendandburns
Copy link
Contributor

We're going to change "name" to "description" to indicate that it's a human readable description, not a referenceable name.

brendandburns added a commit that referenced this pull request Mar 2, 2015
@brendandburns
Merge pull request #4937 from thockin/plural_23_endpoints
9f7b78b 
Stop using named ports in examples and scripts.
@brendandburns brendandburns merged commit 9f7b78b into kubernetes:master Mar 2, 2015
@thockin thockin deleted the plural_23_endpoints branch March 7, 2015 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thockin @sub-mod @brendandburns @googlebot