Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RBAC by default in hack/local-up-cluster.sh #49323

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Enable RBAC by default in hack/local-up-cluster.sh #49323

merged 1 commit into from
Jul 21, 2017

Conversation

mtanino
Copy link

@mtanino mtanino commented Jul 20, 2017 •
edited by liggitt
Loading

What this PR does / why we need it:

Since hack/local-up-cluster.sh checks https API port after commit 413ab26, RBAC should be enabled by default to avoid TLS port access denied.

Which issue this PR fixes : Fixes #49319

Special notes for your reviewer:

@liggitt

Release note:

hack/local-up-cluster.sh now enables RBAC authorization by default

Enable RBAC by default in hack/local-up-cluster.sh
f1351e3 
Since hack/local-up-cluster.sh checks https API port
after commit 413ab26,
RBAC should be enabled by default to avoid TLS port
access denied.

Fixes kubernetes#49319
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mtanino. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 20, 2017
@cblecker
Copy link
Member

/ok-to-test
/cc @liggitt

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2017
@k8s-ci-robot k8s-ci-robot requested a review from liggitt July 20, 2017 19:15
@liggitt
Copy link
Member

liggitt commented Jul 20, 2017

I'm in favor of this change... it makes local-up-cluster more like our other CI/test environments

cc @kubernetes/sig-auth-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jul 20, 2017
@deads2k
Copy link
Contributor

deads2k commented Jul 20, 2017

I'm in favor of this change... it makes local-up-cluster more like our other CI/test environments

Even better, it would fix local-up-cluster.sh for me. :)

lgtm

@liggitt
Copy link
Member

liggitt commented Jul 20, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2017
@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 20, 2017
@deads2k
Copy link
Contributor

deads2k commented Jul 20, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt, mtanino

Associated issue: 49319

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2017
@mtanino
Copy link
Author

mtanino commented Jul 20, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49316, 46117, 49064, 48073, 49323)

@k8s-github-robot k8s-github-robot merged commit 74ce80f into kubernetes:master Jul 21, 2017
@php-coder php-coder mentioned this pull request Jul 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@cblecker cblecker

@zmerlynn zmerlynn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local-up-cluster.sh always fail with "Timed out waiting for apiserver"
7 participants
@mtanino @k8s-ci-robot @cblecker @liggitt @deads2k @k8s-github-robot @zmerlynn