Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug when azure cloud provider configuration file is not specified #49283

Merged
merged 1 commit into from
Aug 10, 2017
Merged

fix bug when azure cloud provider configuration file is not specified #49283

merged 1 commit into from
Aug 10, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Jul 20, 2017

What this PR does / why we need it:

Current Azure cloud provider failed to parse empty config file when --cloud-config is not specified.

GetServicePrincipalToken will raise an error if no valid secrets/tokens are found. So we just need to return empty config obj if --cloud-config is not set.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49228

Special notes for your reviewer:
@githubvick

Release note:

fix bug when azure cloud provider configuration file is not specified

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 20, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 25, 2017

/assign @brendandburns @colemickens

@dixudx
Copy link
Member Author

dixudx commented Jul 25, 2017

/cc @brendandburns @colemickens

@brendandburns
Copy link
Contributor

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, dixudx

Associated issue: 49228

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49642, 50335, 50390, 49283, 46582)

@k8s-github-robot k8s-github-robot merged commit 031a830 into kubernetes:master Aug 10, 2017
@dixudx dixudx deleted the fix_cloudprovider_azure_config branch September 9, 2017 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@colemickens colemickens Awaiting requested review from colemickens

Assignees

@colemickens colemickens

@brendandburns brendandburns

@erictune erictune

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kube-controller-manager fails to start with Azure cloud provider
6 participants
@dixudx @k8s-ci-robot @brendandburns @k8s-github-robot @colemickens @erictune