Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set RBD default values as constant vars #49274

Merged
merged 1 commit into from
Jul 25, 2017
Merged

set RBD default values as constant vars #49274

merged 1 commit into from
Jul 25, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Jul 20, 2017

What this PR does / why we need it:

When working on #49225, I found some default RBD parameters had not been declared as constant values, which will be error-prone.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

set RBD default values as constant vars

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 20, 2017
@gnufied
Copy link
Member

gnufied commented Jul 20, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 21, 2017

@gnufied @rootfs Need your approval. Thanks.

sjenning
sjenning reviewed Jul 21, 2017
View reviewed changes
pkg/volume/rbd/rbd.go
rbdDefaultAdminId = "admin"
rbdDefaultAdminSecretNamespace = "default"
rbdDefaultPool = "rbd"
rbdDefaultUserId = rbdDefaultAdminId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjenning Just declared rbdDefaultUserId here for potential usage.

@rootfs
Copy link
Contributor

rootfs commented Jul 21, 2017

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 21, 2017

@rootfs Seems also need your lgtm. Thanks.

@rootfs
Copy link
Contributor

rootfs commented Jul 21, 2017

@dixudx, please work with @sjenning for lgtm

@dixudx
Copy link
Member Author

dixudx commented Jul 21, 2017

@rootfs Thanks for your help.

@sjenning Any comments?

@sjenning
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, rootfs, sjenning

Associated issue: 49225

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dixudx
Copy link
Member Author

dixudx commented Jul 24, 2017

/retest

@sjenning sjenning mentioned this pull request Jul 25, 2017
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48911, 49475, 49438, 49362, 49274)

@k8s-github-robot k8s-github-robot merged commit ee7eb4a into kubernetes:master Jul 25, 2017
@dixudx dixudx deleted the add_const_for_rbd branch July 25, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning sjenning left review comments

Assignees

@sjenning sjenning

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dixudx @k8s-ci-robot @gnufied @rootfs @sjenning @k8s-github-robot @smarterclayton