Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set default adminid for rbd deleter if unset #49271

Merged
merged 1 commit into from
Jul 26, 2017
Merged

set default adminid for rbd deleter if unset #49271

merged 1 commit into from
Jul 26, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Jul 20, 2017 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49225

Special notes for your reviewer:
/cc @BastiPaeltz @sjenning

Release note:

set default adminid for rbd deleter if unset

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 20, 2017
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dixudx dixudx force-pushed the fix_rbd_deleter_adminid branch from e1ff839 to 3c0bb59 Compare July 20, 2017 08:38
@dixudx
Copy link
Member Author

dixudx commented Jul 25, 2017

@sjenning PTAL. Thanks.

@sjenning
Copy link
Contributor

@dixudx your PR #49274 is in the submit queue. After it merges you will need to rebase this PR. I'll take a look after that.

@sjenning
Copy link
Contributor

/assign

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2017
@dixudx dixudx force-pushed the fix_rbd_deleter_adminid branch from 3c0bb59 to 6addd4c Compare July 25, 2017 04:51
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 25, 2017

@sjenning Rebased. PTAL. Thanks so much.

@dixudx
Copy link
Member Author

dixudx commented Jul 25, 2017

/cc @sjenning @rootfs

@k8s-ci-robot k8s-ci-robot requested review from rootfs and sjenning July 25, 2017 14:35
@sjenning
Copy link
Contributor

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 26, 2017

/test pull-kubernetes-e2e-gce-etcd3

@dixudx
Copy link
Member Author

dixudx commented Jul 26, 2017

/retest

@dixudx
Copy link
Member Author

dixudx commented Jul 26, 2017

@rootfs Need your /approval. Thanks.

@rootfs
Copy link
Contributor

rootfs commented Jul 26, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, rootfs, sjenning

Associated issue: 49225

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 26, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47357, 49514, 49271, 49572, 49476)

@k8s-github-robot k8s-github-robot merged commit 74b3d47 into kubernetes:master Jul 26, 2017
@dixudx dixudx deleted the fix_rbd_deleter_adminid branch July 26, 2017 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning sjenning approved these changes

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@sjenning sjenning

@saad-ali saad-ali

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RBD StorageClass - default adminId not used when deleting volume
7 participants
@dixudx @k8s-ci-robot @sjenning @rootfs @k8s-github-robot @saad-ali @jingxu97