Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken validation tips and typo in ubuntu-multi-nodes-guide #4925

Merged
merged 1 commit into from
Mar 3, 2015

Conversation

resouer
Copy link
Contributor

@resouer resouer commented Feb 28, 2015

Fix:

  1. validation tips broke the list in doc
  2. fix typo in command line

@resouer resouer force-pushed the patch-1 branch 2 times, most recently from 3d61531 to e4cbf77 Compare February 28, 2015 03:21
@resouer resouer changed the title Fix broken validation tips and typo in guide Fix broken validation tips and typo in ubuntu-multi-nodes-guide Feb 28, 2015
@zmerlynn
Copy link
Member

LGTM

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2015
@@ -112,15 +114,14 @@ If you want a node acts as **both running the master and minion**, please choose

> `$ /opt/bin/etcdctl get /coreos.com/network/config`

> If you got `{"Network":"10.0.0.0/16"}`,then etcd cluster is working in good condition. **Victory is in sight!**
> If not , you should check` /var/log/upstart/etcd.log` to resolve etcd problem before going forward.
> If got `{"Network":"10.0.0.0/16"}`, then etcd cluster is working well.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/If got/If you got/

@bgrant0607 bgrant0607 removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2015
@bgrant0607
Copy link
Member

Please fix the typo, and we'd be happy to merge.

@resouer
Copy link
Contributor Author

resouer commented Mar 3, 2015

@rjnagal Aha, I'll fix it soon. btw, do you think it is reasonable to change the file name to ubuntu_multi_nodes_cluster.md? I'm also not sure if its current name is perfect ...

@rjnagal
Copy link
Contributor

rjnagal commented Mar 3, 2015

I think we should just merge the multiple ubuntu guides into one ubuntu.md.
Running everything on a single node should just be a special case of
multi-node configuration.

On Mon, Mar 2, 2015 at 9:18 PM, Harry Zhang notifications@github.com
wrote:

@rjnagal https://github.com/rjnagal Aha, I'll fix it soon. btw, do you
think it is reasonable to change the file name to
ubuntu_multi_nodes_cluster.md? I'm also not sure if its current name is
linguistic right ...


Reply to this email directly or view it on GitHub
#4925 (comment)
.

Fix:
1. validation tips broken the list in doc
2. fix typo in command line
@resouer
Copy link
Contributor Author

resouer commented Mar 3, 2015

@bgrant0607 @rjnagal Typo fixed, please ship it. We are also informed that single node setup should be deprecated. So we'd like to give a shoot to merge existed ubuntu scripts&docs in another PR if maintainers have reached agreement.

@bgrant0607 bgrant0607 assigned rjnagal and unassigned zmerlynn Mar 3, 2015
@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2015
@bgrant0607
Copy link
Member

LGTM for this PR. Merging multi-node and single-node can be a separate PR.

rjnagal added a commit that referenced this pull request Mar 3, 2015
Fix broken validation tips and typo in ubuntu-multi-nodes-guide
@rjnagal rjnagal merged commit a02194d into kubernetes:master Mar 3, 2015
@resouer resouer deleted the patch-1 branch March 4, 2015 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants