-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken validation tips and typo in ubuntu-multi-nodes-guide #4925
Conversation
3d61531
to
e4cbf77
Compare
LGTM |
@@ -112,15 +114,14 @@ If you want a node acts as **both running the master and minion**, please choose | |||
|
|||
> `$ /opt/bin/etcdctl get /coreos.com/network/config` | |||
|
|||
> If you got `{"Network":"10.0.0.0/16"}`,then etcd cluster is working in good condition. **Victory is in sight!** | |||
> If not , you should check` /var/log/upstart/etcd.log` to resolve etcd problem before going forward. | |||
> If got `{"Network":"10.0.0.0/16"}`, then etcd cluster is working well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/If got/If you got/
Please fix the typo, and we'd be happy to merge. |
@rjnagal Aha, I'll fix it soon. btw, do you think it is reasonable to change the file name to |
I think we should just merge the multiple ubuntu guides into one ubuntu.md. On Mon, Mar 2, 2015 at 9:18 PM, Harry Zhang notifications@github.com
|
Fix: 1. validation tips broken the list in doc 2. fix typo in command line
@bgrant0607 @rjnagal Typo fixed, please ship it. We are also informed that single node setup should be deprecated. So we'd like to give a shoot to merge existed ubuntu scripts&docs in another PR if maintainers have reached agreement. |
LGTM for this PR. Merging multi-node and single-node can be a separate PR. |
Fix broken validation tips and typo in ubuntu-multi-nodes-guide
Fix: