Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apps/v1beta2.ReplicaSet #49238

Merged
merged 3 commits into from
Jul 28, 2017
Merged

Add apps/v1beta2.ReplicaSet #49238

merged 3 commits into from
Jul 28, 2017

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Jul 19, 2017 •
edited
Loading

Depends on #48746 (merged)
Depends on #49357 (merged)
xref: #49135

Add a new API object apps/v1beta2.ReplicaSet

@janetkuo janetkuo added this to the v1.8 milestone Jul 19, 2017
@janetkuo janetkuo self-assigned this Jul 19, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2017
@k8s-github-robot k8s-github-robot added kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 19, 2017
@janetkuo janetkuo mentioned this pull request Jul 20, 2017
Closed
@janetkuo janetkuo assigned kow3ns and unassigned janetkuo Jul 20, 2017
@janetkuo janetkuo force-pushed the apps-v1beta2-rs branch 2 times, most recently from b722403 to 03fcd6a Compare July 20, 2017 19:28
@janetkuo
Copy link
Member Author

hit #49320:

/test pull-kubernetes-federation-e2e-gce

@kow3ns kow3ns mentioned this pull request Jul 21, 2017
Closed
11 tasks
@janetkuo
Copy link
Member Author

janetkuo commented Jul 21, 2017 •
edited
Loading

hit #49413:
/test pull-kubernetes-unit

@janetkuo janetkuo force-pushed the apps-v1beta2-rs branch 2 times, most recently from cd159bb to b05e545 Compare July 22, 2017 00:25
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2017
@enisoc
Copy link
Member

enisoc commented Jul 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2017
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 24, 2017
@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2017
@janetkuo
Copy link
Member Author

Just a rebase. Re-applying the tag

@janetkuo
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@janetkuo
Copy link
Member Author

/assign @smarterclayton
Needs approval

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2017
janetkuo added 2 commits July 26, 2017 09:51
@janetkuo
Bump ReplicaSet to apps/v1beta2
6eaf688
@janetkuo
Fix ReplicaSet federation e2e test: use explicit cluster.ReplicaSets
b4d06c5 
test/e2e_federation/replicaset.go complains: ambiguous selector
cluster.ReplicaSets
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 26, 2017
@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2017
@janetkuo
Copy link
Member Author

Another rebase

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2017
@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2017
@janetkuo
Copy link
Member Author

/test pull-kubernetes-e2e-gce-etcd3

@bgrant0607
Copy link
Member

/approve

@bgrant0607 bgrant0607 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, enisoc, janetkuo

Associated issue: 48746

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@janetkuo
Copy link
Member Author

/test pull-kubernetes-e2e-gce-etcd3

2 similar comments
@janetkuo
Copy link
Member Author

/test pull-kubernetes-e2e-gce-etcd3

@dixudx
Copy link
Member

dixudx commented Jul 27, 2017

/test pull-kubernetes-e2e-gce-etcd3

@janetkuo
Copy link
Member Author

The test failure is #49672

@janetkuo janetkuo mentioned this pull request Jul 27, 2017
Closed
@janetkuo
Copy link
Member Author

/test pull-kubernetes-e2e-gce-etcd3

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49238, 49595, 43494, 47897, 48905)

@k8s-github-robot k8s-github-robot merged commit 7056b5b into kubernetes:master Jul 28, 2017
@WanLinghao WanLinghao mentioned this pull request Sep 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enisoc enisoc

@bgrant0607 bgrant0607

@kow3ns kow3ns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
8 participants
@janetkuo @enisoc @bgrant0607 @k8s-github-robot @dixudx @smarterclayton @kow3ns @k8s-ci-robot