Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use informers for quota evaluation of core resources where possible #49230

Merged
merged 1 commit into from
Jul 20, 2017
Merged

use informers for quota evaluation of core resources where possible #49230

merged 1 commit into from
Jul 20, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 19, 2017 •
edited by derekwaynecarr
Loading

Not all quota evaluators are using shared informers. This updates them all to have the option of doing it.

Fixes #49233

resource quota uses shared informers for core types

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Jul 19, 2017
@derekwaynecarr
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 19, 2017
@derekwaynecarr
Copy link
Member

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, derekwaynecarr

Associated issue requirement bypassed by: derekwaynecarr

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2017
@derekwaynecarr derekwaynecarr added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-label-needed labels Jul 19, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2017
@deads2k deads2k removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 19, 2017
@derekwaynecarr
Copy link
Member

added the issue to make bot happy.

@derekwaynecarr
Copy link
Member

/test pull-kubernetes-federation-e2e-gce

@spxtr
Copy link
Contributor

spxtr commented Jul 19, 2017

/lint

k8s-ci-robot
k8s-ci-robot reviewed Jul 19, 2017
View reviewed changes
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spxtr: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jul 19, 2017
Merged
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49218, 48253, 48967, 48460, 49230)

@k8s-github-robot k8s-github-robot merged commit e48ad77 into kubernetes:master Jul 20, 2017
@deads2k deads2k deleted the quota-02-informer branch August 3, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k8s-ci-robot k8s-ci-robot k8s-ci-robot left review comments

Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @derekwaynecarr @k8s-github-robot @spxtr @k8s-ci-robot