@ironcladlou @derekwaynecarr @bparees
On Fri, Feb 27, 2015 at 8:04 PM Daniel Smith notifications@github.com
wrote:

Part 1 of several for #4877
#4877.

This PR doesn't change any behavior; the new functionality is off
everywhere.

This is necessary, but not yet sufficient, to refactor our current

replication controller to be more like our scheduler.

You can view, comment on, or merge this pull request online at:

#4923
Commit Summary

• clean up poller test to not make infinite log messages
• add occasional polling to reflector

File Changes

• M pkg/client/cache/poller_test.go
  https://github.com/GoogleCloudPlatform/kubernetes/pull/4923/files#diff-0
  (4)
• M pkg/client/cache/reflector.go
  https://github.com/GoogleCloudPlatform/kubernetes/pull/4923/files#diff-1
  (100)
• M pkg/client/cache/reflector_test.go
  https://github.com/GoogleCloudPlatform/kubernetes/pull/4923/files#diff-2
  (38)
• M pkg/kubelet/config/apiserver.go
  https://github.com/GoogleCloudPlatform/kubernetes/pull/4923/files#diff-3
  (2)
• M pkg/kubelet/kubelet.go
  https://github.com/GoogleCloudPlatform/kubernetes/pull/4923/files#diff-4
  (7)
• M plugin/pkg/admission/namespace/autoprovision/admission.go
  https://github.com/GoogleCloudPlatform/kubernetes/pull/4923/files#diff-5
  (1)
• M plugin/pkg/admission/namespace/exists/admission.go
  https://github.com/GoogleCloudPlatform/kubernetes/pull/4923/files#diff-6
  (1)
• M plugin/pkg/scheduler/factory/factory.go
  https://github.com/GoogleCloudPlatform/kubernetes/pull/4923/files#diff-7
  (8)

Patch Links:

• https://github.com/GoogleCloudPlatform/kubernetes/pull/4923.patch
• https://github.com/GoogleCloudPlatform/kubernetes/pull/4923.diff

—
Reply to this email directly or view it on GitHub
#4923.

I like where this is going. Taking the conversation about delete handling over to #4877 for now.

This PR is LGTM.

Per our discussion, will you look to make reflector.resourceVersion somehow available to the cache.Store so I can do the pattern of asking a store if its state has changed since I last viewed it?