Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some more deprecation warnings to cluster #49148

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Jul 18, 2017

Part of #49213
@kubernetes/sig-cluster-lifecycle-misc

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 18, 2017

!!! DEPRECATION NOTICE !!!

The '${provider}' kube-up provider is deprecated and will be removed in a future
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue or announcement we can link to here to provide more context about the deprecation? Also, if someone sees this message and immediately panics and wants to convince us not to remove this support, how should they proceed? A little clarity up front will help us organize any support pings we get in the future.

Copy link
Member

@luxas luxas Jul 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @pipejakob said
Also we could state the timeline up front here (removal in v1.9?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luxas @pipejakob Done. GCE is going to be a PITA to remove and it's currently unstaffed so I'm leaving it out of the list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikedanese sounds reasonable to defer that.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jul 18, 2017
@luxas luxas added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-label-needed labels Jul 19, 2017
@luxas luxas added this to the v1.8 milestone Jul 19, 2017
@kubernetes kubernetes deleted a comment from k8s-github-robot Jul 19, 2017
@kubernetes kubernetes deleted a comment from k8s-ci-robot Jul 19, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2017
@luxas
Copy link
Member

luxas commented Jul 19, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, mikedanese

Associated issue: 49213

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48377, 48940, 49144, 49062, 49148)

@k8s-github-robot k8s-github-robot merged commit 2eb6b95 into kubernetes:master Jul 20, 2017
@mikedanese mikedanese deleted the deprecate-cluster branch July 20, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants