-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some more deprecation warnings to cluster #49148
add some more deprecation warnings to cluster #49148
Conversation
bc407a4
to
428de6b
Compare
|
||
!!! DEPRECATION NOTICE !!! | ||
|
||
The '${provider}' kube-up provider is deprecated and will be removed in a future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue or announcement we can link to here to provide more context about the deprecation? Also, if someone sees this message and immediately panics and wants to convince us not to remove this support, how should they proceed? A little clarity up front will help us organize any support pings we get in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What @pipejakob said
Also we could state the timeline up front here (removal in v1.9?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luxas @pipejakob Done. GCE is going to be a PITA to remove and it's currently unstaffed so I'm leaving it out of the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikedanese sounds reasonable to defer that.
428de6b
to
89bf771
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luxas, mikedanese Associated issue: 49213 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 48377, 48940, 49144, 49062, 49148) |
Part of #49213
@kubernetes/sig-cluster-lifecycle-misc