Fix findmnt parsing in containerized kubelet #49111
Merged
+85
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NsEnterMounter should not stop parsing findmnt output on the first space but on the last one, just in case the mount point name itself contains a space.
k8s-ci-robot
added
sig/storage
k8s-github-robot
added
size/S
rootfs
reviewed
Jul 18, 2017
| @@ -213,6 +216,18 @@ func (n *NsenterMounter) IsLikelyNotMountPoint(file string) (bool, error) { | |||
| return true, nil | |||
| } | |||
|
|
|||
| // parse output of "findmnt -o target,fstype" and return just the target | |||
| func parseFindMnt(out string) (string, error) { | |||
There was a problem hiding this comment.
a sample output or a unit test will help
There was a problem hiding this comment.
I forgot to add the test to the commit :-o
|
/lgtm |
k8s-ci-robot
added
the
lgtm
jsafrane
force-pushed
the
nsenter-path-space
branch
from
cdfc969 to
8755107
Compare
k8s-github-robot
added
size/M
This was referenced Jul 20, 2017
Merged
|
This LGTM, but I don't have approval in here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, jsafrane, rootfs Associated issue: 49106 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/retest |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NsEnterMounter should not stop parsing findmnt output on the first space but on the last one, just in case the mount point name itself contains a space.
Fixes #49106
@kubernetes/sig-storage-pr-reviews