Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix if condition in cluster/log-dump/log-dump.sh #49040

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

shyamjvs
Copy link
Member

Fixes #49039

/cc @yujuhong

@k8s-ci-robot k8s-ci-robot requested a review from yujuhong July 17, 2017 18:22
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 17, 2017
@shyamjvs shyamjvs added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 17, 2017
@shyamjvs
Copy link
Member Author

@mikedanese Could you approve this?

@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2017
@shyamjvs
Copy link
Member Author

/test pull-kubernetes-federation-e2e-gce

@yujuhong
Copy link
Contributor

/lgtm

@yujuhong
Copy link
Contributor

Debugging test failures without logs is annoying. Adding a couple of folks for approval: @wojtek-t @zmerlynn

@zmerlynn
Copy link
Member

/lgtm /approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, shyamjvs, yujuhong, zmerlynn

Associated issue: 49039

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49019, 48919, 49040, 49018, 48874)

@k8s-github-robot k8s-github-robot merged commit 3548031 into kubernetes:master Jul 18, 2017
@shyamjvs shyamjvs deleted the fix-logdump branch July 18, 2017 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants