Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent unsetting of nonexistent previous port in kubeapi-load-balancer charm #49033

Merged
merged 1 commit into from
Jul 18, 2017
Merged

prevent unsetting of nonexistent previous port in kubeapi-load-balancer charm #49033

merged 1 commit into from
Jul 18, 2017

Conversation

wwwtyro
Copy link
Contributor

@wwwtyro wwwtyro commented Jul 17, 2017

What this PR does / why we need it: prevent unsetting of nonexistent previous port in kubeapi-load-balancer charm

Release note:

prevent unsetting of nonexistent previous port in kubeapi-load-balancer charm

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @wwwtyro. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 17, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 17, 2017
@wwwtyro
Copy link
Contributor Author

wwwtyro commented Jul 17, 2017

/assign @Cynerva

@Cynerva
Copy link
Contributor

Cynerva commented Jul 17, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 17, 2017
@Cynerva
Copy link
Contributor

Cynerva commented Jul 17, 2017

Ah yeah, missed this in the last review. config.previous can sometimes return None so we need to account for that here. 👍

/approve no-issue
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, wwwtyro

Associated issue requirement bypassed by: Cynerva

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48231, 47377, 48797, 49020, 49033)

@k8s-github-robot k8s-github-robot merged commit 50ec438 into kubernetes:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikedanese mikedanese

@Cynerva Cynerva

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wwwtyro @k8s-ci-robot @Cynerva @k8s-github-robot @mikedanese @thockin